deploy on python 3.12 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
- only run ruff checks once - fail the build on format errors with --check - remove thin aliases
`pipenv run pytest` does the same thing with or without this
chris48s
force-pushed
the
upgrades202408
branch
from
f98ae8d to
8fe0aed
Compare
chris48s
force-pushed
the
upgrades202408
branch
2 times, most recently
from
153effb to
ca53e75
Compare
VirginiaDooley
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the project to upgrade all our tier 1 applications to use
and to adopt
This project doesn't use a lot of the things in that list so its really just changes related to python 3.12 and ruff here plus a few minor bits of scope creep.
As well as local testing, I did test deploying this to dev, which I have since reverted 153effb