Merge pull request #128 from DemocracyClub/hotfix/conditional-releases

Fix conditional statement for release
DemocracyClub · Apr 16, 2024 · dafa78d · dafa78d
2 parents fc48d92 + 481d955
commit dafa78d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -1,17 +1,15 @@
 name: Publish Python Package
 
 on:
+  release:
+    types: [created]
   workflow_run:
-    workflows: ["Run Tests"]
+    workflows: ["Run Tests"] 
     types:
       - completed
     branches:
       - master
-  if: ${{ github.event.workflow_run.conclusion == 'success' }}
 
-  release:
-    types: [created]
-
 jobs:
   test:
     runs-on: ubuntu-latest
@@ -31,6 +29,7 @@ jobs:
         pip install --upgrade pip
         pip install -e '.[test]'
   deploy:
+    if: ${{ github.event.workflow_run.conclusion == 'success' }}
     runs-on: ubuntu-latest
     needs: [test]
     environment: release

diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -23,7 +23,4 @@ jobs:
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install -r requirements.txt
-      - name: Run tests
-        run: pytest