Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/slack notifications #1852

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

VirginiaDooley
Copy link
Contributor

@VirginiaDooley VirginiaDooley commented May 2, 2024

Ref #1689

I tested this config by temporarily adding a failing test and the notifications setup to the test and build job.
Screenshot 2024-05-14 at 2 11 44 PM


@VirginiaDooley VirginiaDooley force-pushed the hotfix/slack-notifications branch from 8fb480a to 813b990 Compare May 2, 2024 12:21
@coveralls
Copy link

coveralls commented May 2, 2024

Coverage Status

coverage: 60.068%. remained the same
when pulling 3b8250a on hotfix/slack-notifications
into 411dbeb on master.

@VirginiaDooley VirginiaDooley force-pushed the hotfix/slack-notifications branch from 813b990 to cd905b2 Compare May 2, 2024 12:27
@symroe
Copy link
Member

symroe commented May 14, 2024

If you're using webhooks then do we still need the Slack orb?

And if the API has changed, then does that mean the orb no longer works? It was last updated in March, so I suspect it's still ok.

Can you either explore the org more (It's likely to be more robust when working) or remove it and just use the webbook?

@VirginiaDooley VirginiaDooley force-pushed the hotfix/slack-notifications branch 6 times, most recently from eb721de to 65fa950 Compare May 14, 2024 13:15
@VirginiaDooley
Copy link
Contributor Author

If you're using webhooks then do we still need the Slack orb?

And if the API has changed, then does that mean the orb no longer works? It was last updated in March, so I suspect it's still ok.

Can you either explore the org more (It's likely to be more robust when working) or remove it and just use the webbook?

Started from scratch with the orb setup and it worked!

@VirginiaDooley VirginiaDooley requested a review from symroe May 14, 2024 13:16
- Upgrade slack orb 4.13.2
- change cimg
@VirginiaDooley VirginiaDooley force-pushed the hotfix/slack-notifications branch from 65fa950 to 3b8250a Compare May 14, 2024 13:19
@VirginiaDooley VirginiaDooley merged commit 89cf8be into master May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants