Party list page filtering

[Bekabyx]

Asana

This work adds filters to the party list page @ /parties/ and updates the descriptive text at the top of the page. Text changes were spitballed between Peter and I but this can be modified if you have any suggestions on how to improve it 📈

Initially the filters only include the most high level categories - nation, register and status.

Most of the code which handles the filtering has been lifted from YNR's photo review filter code, as that implements both advanced filters and "shortcut" filters which were useful in this scenario. Shortcut filters allow us to have "quick filters" spanning multiple fields and values (e.g. a quick one-click filter for "Deregistered parties in Great Britain"). The advanced filters allow the user to curate their own filter and add functionality that allows the user to filter for nation - applicable to GB parties which must specify which nation(s) they operate in.

NB: The nations filter is inclusive. That is to say, if you filter for "Wales" you will get parties that include Wales within their nation list, but may also contain other nations in their nation list. There is no way to filter for parties that stand exclusively in one or two nations.

To Test

Set-up

• You have probably done this already, but make sure you're up to date on migrations and you've run manage.py import_parties. You need the nations for this one!

Quick filters

Work through the four quick filters. In some cases it's impossible to check exhaustively, but just a couple of parties checked should be sufficient :)

• Registered in Great Britain and Registered in Northern Ireland shouldn't show any parties which have (Deregistered) after their names.
• All parties shown for Deregistered in Great Britain and Deregistered in Northern Ireland should show (Deregistered) after their names
• All parties shown for Deregistered in Great Britain and Registered in Great Britain should be on the Great Britain register
• All parties shown for Deregistered in Northern Ireland and Registered in Northern Ireland should be on the Northern Ireland register

Advanced filters

This is mostly just "having a play" and combining the filters. The quick filters rely on the advanced filters to function, so no additional steps will be given for party register and party status because there's no need to test twice.

Nations

• Check that when you filter "Wales" you don't get parties only registered in one other nation, e.g. SNP
• Check that when you filter "Scotland" you don't get parties only registered in one other nation, e.g. PC
• Check that when you filter "England" you don't get parties only registered in one other nation, e.g. SNP, PC
• Check that when you filter nations = (one of ENG,WAL,SCO) and filter register = Northern Ireland no parties are shown

PR Checklist

Preview Give feedback

1. References a specific issue or if not, describes the bug or feature in detail
2. Note what card in Trello this work relates to
3. Instructions for how reviewers can test the code locally
4. Screenshot of the feature/bug fix (if applicable)
5. If any new text is added, it's internationalized

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1205092272461905

[coveralls]

coverage: 61.454% (+0.5%) from 60.931% when pulling e2037ec on feature/party_filters into 6059f98 on master.

[VirginiaDooley]

Test as instructed, works well 👍