-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide inactive users from the blog post author dropdown #546
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
=======================================
Coverage 70.01% 70.01%
=======================================
Files 41 41
Lines 637 637
=======================================
Hits 446 446
Misses 191 191
Continue to review full report at Codecov.
|
45f1985
to
24d6fc9
Compare
TIL Can you check one thing though: If we edit an old blog post with an inactive user, what happens? So the steps would be:
|
Since the original author has been marked inactive, I am prompted to choose an active author from the list to save the edited post.
Yes, removed. |
Hmm, in that case, I think we might need another approach here, as we want to keep old authors if we edit their posts (for whatever reason). Can you take a look at the |
Closes #535
With this work, blog posts can only be assigned to active authors.