Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed unncessary logs #67

Merged
merged 1 commit into from
Jul 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -517,29 +517,29 @@ export class PSQLRecordOperationWatcher extends EventEmitter {
this.log(JSON.stringify({ base }));

await this.setupSQLResources(baseData, newModels);
this.log('finished seting up sql resources ...');
// this.log('finished seting up sql resources ...');

this.log('about to consume notifications');
// this.log('about to consume notifications');
void this.consumeNotifications(baseData);
this.log('finished consuming notifications ..... ');
// this.log('finished consuming notifications ..... ');

if (createNewBaseData || rewatch) {
const connection = await baseData.knex.client.acquireConnection();

this.log('about to register listeners');
// this.log('about to register listeners');
// start watching
// ///////////
await this.registerListeners(baseData, connection);
this.log('finished registering listeners ...');
// this.log('finished registering listeners ...');
}

this.log('about to dispose sql resources for obsolete models');
// this.log('about to dispose sql resources for obsolete models');
await Promise.all(
obsoleteModels.map((obsoleteModel) =>
this.disposeSQLResourcesForModel(baseData, obsoleteModel)
)
);
this.log('done disposing sql resources for obsolete models ....');
// this.log('done disposing sql resources for obsolete models ....');

this.allBaseData.set(base.id, baseData);
}
Expand Down
8 changes: 4 additions & 4 deletions packages/nocodb/src/lib/models/Project.ts
Original file line number Diff line number Diff line change
Expand Up @@ -355,14 +355,14 @@ export default class Project implements ProjectType {
}

static async getByTitleOrId(titleOrId: string, ncMeta = Noco.ncMeta) {
console.log('about to check cache for project ref titleOrId');
// console.log('about to check cache for project ref titleOrId');
const projectId =
titleOrId &&
(await NocoCache.get(
`${CacheScope.PROJECT}:ref:${titleOrId}`,
CacheGetType.TYPE_OBJECT
));
console.log('finished checking cache for project ref titleOrId');
// console.log('finished checking cache for project ref titleOrId');
let projectData = null;
if (!projectId) {
projectData = await Noco.ncMeta.metaGet2(
Expand All @@ -388,12 +388,12 @@ export default class Project implements ProjectType {
],
}
);
console.log('about to set project ref titleOrId in cache');
// console.log('about to set project ref titleOrId in cache');
await NocoCache.set(
`${CacheScope.PROJECT}:ref:${titleOrId}`,
projectData?.id
);
console.log('finished to set project ref titleOrId in cache');
// console.log('finished to set project ref titleOrId in cache');
} else {
return this.get(projectId);
}
Expand Down