Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

기능구현 - 유저정보CRUD(CREATE) (#6) #11

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

기능구현 - 유저정보CRUD(CREATE) (#6) #11

wants to merge 7 commits into from

Conversation

K-im-jinwoo
Copy link
Contributor

개요

유저정보 CRUD 기능 중 CREATE구현

구현

  • Sign up interface 구현
  • Sign up Form 구현
  • Sign up axios 구현
  • StatusCode에 따른 처리

@K-im-jinwoo K-im-jinwoo requested review from yejun614, 98StarJune and a team May 23, 2023 03:04
@K-im-jinwoo K-im-jinwoo added the enhancement 새 기능 또는 요청 label May 23, 2023
@K-im-jinwoo K-im-jinwoo changed the title 기능구현 - 유저정보CRUD(Create) 기능구현 - 유저정보CRUD(CREATE) (#6) May 23, 2023
98StarJune
98StarJune reviewed May 24, 2023
View reviewed changes
Copy link
Member

@98StarJune 98StarJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드리뷰 전달합니다

아래 내용을 확인해주시면 감사하겠습니다.

src/pages/signup.tsx Outdated
} else if (response.status === 400) {
// 잘못된 요청인 경우
// false 데이터 다시 작성해달라고 요청하기
const { data } = response;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타입을 지정할 수 있습니다

서버와의 통신의 결과로 받아오는 데이터는 합의를 통해 이미 정해져있습니다. 가능하다면 파트원분과 협의해 interface로 정의할 것을 추천합니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정완료 했습니다.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@98StarJune 98StarJune 98StarJune left review comments

@yejun614 yejun614 Awaiting requested review from yejun614

Assignees
No one assigned
Labels
enhancement 새 기능 또는 요청
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@K-im-jinwoo @98StarJune