Cleanup

DecentSoftware-eu · Oct 2, 2023 · 981b623 · 981b623
1 parent 46c9655
commit 981b623
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 28 deletions.
diff --git a/...-holograms-api/src/main/java/eu/decentsoftware/holograms/api/hologram/HologramConfig.java b/...-holograms-api/src/main/java/eu/decentsoftware/holograms/api/hologram/HologramConfig.java
@@ -50,14 +50,14 @@ public interface HologramConfig {
     /**
      * Save the hologram file.
      *
-     * @return True if the operation was successful, false otherwise in a {@link CompletableFuture}.
+     * @return CompletableFuture that completes when the operation is finished.
      */
     CompletableFuture<Void> save();
 
     /**
      * Reload the hologram file.
      *
-     * @return True if the operation was successful, false otherwise in a {@link CompletableFuture}.
+     * @return CompletableFuture that completes when the operation is finished.
      */
     CompletableFuture<Void> reload();
 

diff --git a/...ams-api/src/main/java/eu/decentsoftware/holograms/api/hologram/line/HologramLineType.java b/...ams-api/src/main/java/eu/decentsoftware/holograms/api/hologram/line/HologramLineType.java
@@ -50,9 +50,5 @@ public enum HologramLineType {
      * A line displaying an Entity.
      */
     ENTITY,
-    /**
-     * A line, made of multiple lines, displaying an image.
-     */
-    IMAGE,
     UNKNOWN
 }
diff --git a/...t-holograms-v1_8_R2/src/main/java/eu/decentsoftware/holograms/nms/NMSAdapter_v1_8_R2.java b/...t-holograms-v1_8_R2/src/main/java/eu/decentsoftware/holograms/nms/NMSAdapter_v1_8_R2.java
@@ -324,16 +324,9 @@ public int getFreeEntityId() {
         }
     }
 
+    @SuppressWarnings("deprecation")
     @Override
     public int getEntityTypeId(EntityType type) {
-        // TODO: Find a better way to get the entity type id
-        if (type == EntityType.ARMOR_STAND) {
-            return 30;
-        }
-        if (type == EntityType.DROPPED_ITEM) {
-            return 2;
-        }
-        // noinspection deprecation
         return ENTITY_TYPE_NAME_ID_MAP == null ? type.getTypeId() : ENTITY_TYPE_NAME_ID_MAP.get(type.getName());
     }
 

diff --git a/...t-holograms-v1_8_R3/src/main/java/eu/decentsoftware/holograms/nms/NMSAdapter_v1_8_R3.java b/...t-holograms-v1_8_R3/src/main/java/eu/decentsoftware/holograms/nms/NMSAdapter_v1_8_R3.java
@@ -328,16 +328,9 @@ public int getFreeEntityId() {
         }
     }
 
+    @SuppressWarnings("deprecation")
     @Override
     public int getEntityTypeId(EntityType type) {
-        // TODO: Find a better way to get the entity type id
-//        if (type == EntityType.ARMOR_STAND) {
-//            return 30;
-//        }
-//        if (type == EntityType.DROPPED_ITEM) {
-//            return 2;
-//        }
-        // noinspection deprecation
         return ENTITY_TYPE_NAME_ID_MAP == null ? type.getTypeId() : ENTITY_TYPE_NAME_ID_MAP.get(type.getName());
     }
 

diff --git a/...ograms-plugin/src/main/java/eu/decentsoftware/holograms/animations/AnimationRegistry.java b/...ograms-plugin/src/main/java/eu/decentsoftware/holograms/animations/AnimationRegistry.java
@@ -83,7 +83,6 @@ public synchronized void reload() {
         this.stepCounter.set(0);
 
         // Register default animations
-        //  TODO: Handle colors in frame data
         this.registerAnimation(new RainbowAnimation());
         this.registerAnimation(new WaveAnimation());
         this.registerAnimation(new BurnAnimation());

diff --git a/...s-plugin/src/main/java/eu/decentsoftware/holograms/hologram/line/DefaultHologramLine.java b/...s-plugin/src/main/java/eu/decentsoftware/holograms/hologram/line/DefaultHologramLine.java
@@ -35,11 +35,6 @@
 
 public class DefaultHologramLine implements HologramLine {
 
-    /*
-     * TODO:
-     *  - Hover content for text lines
-     */
-
     private final @NotNull HologramPage parent;
     private final @NotNull HologramLineSettings settings;
     private final @NotNull PositionManager positionManager;

diff --git a/...lograms-plugin/src/main/java/eu/decentsoftware/holograms/utils/pinger/PingerResponse.java b/...lograms-plugin/src/main/java/eu/decentsoftware/holograms/utils/pinger/PingerResponse.java
@@ -24,7 +24,10 @@
 
 /**
  * This class stores data about a pinged server.
+ *
+ * @since 3.0.0
  */
+@SuppressWarnings("unused")
 @Getter
 public class PingerResponse {
-Original file line number
+Diff line change
@@ Expand Up / @@ -50,9 +50,5 @@ public enum HologramLineType { @@
          * A line displaying an Entity.
          */
         ENTITY,
-        /**
-         * A line, made of multiple lines, displaying an image.
-         */
-        IMAGE,
         UNKNOWN
     }