Allow inserting hologram lines at the end of the list #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, inserting at the end of the hologram required workarounds as the index check did not permit it. This change updates the logic to allow an index equal to `size()`, enabling straightforward insertion at the end. It improves functionality and aligns with expected behavior.
Replaced redundant code in the addLine method with a call to insertLine to improve code clarity and maintainability. This ensures consistent behavior and reduces duplication, streamlining future updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #267
Previously, inserting at the end of the hologram required workarounds as the index check did not permit it. This change updates the logic to allow an index equal to
size(), enabling straightforward insertion at the end. It improves functionality and aligns with expected behavior.