Added actions #198
Added actions #198
Conversation
| @@ -3,7 +3,7 @@ | |||
| import org.bukkit.event.block.Action; | |||
|
|
|||
| public enum ClickType { | |||
| LEFT, RIGHT, SHIFT_LEFT, SHIFT_RIGHT; | |||
| LEFT, RIGHT, SHIFT_LEFT, SHIFT_RIGHT,HOVER,HOVER_LEAVE; | |||
There was a problem hiding this comment.
Not a fan of a non-click action (just looking at a page/line) being in a enum specifically for click types.
Given this would only be looking and not looking at a hologram can this be just some lists of actions or similar in the Hologram itself, rather than dedicate an entire type to it.
There was a problem hiding this comment.
Thank you for your reply,But I think hovering the mouse over the hologram should also be considered a ClickType. If we put them into actions, it would lose its meaning, as it would be triggered by LEFT_CLICK or RIGHT_CLICK instead of when the mouse hovers over the hologram.
While I acknowledge that my programming skills may have room for improvement, I am open to further discussion and finding a solution that best aligns with the project's needs. What are your thoughts on this approach?
There was a problem hiding this comment.
I'm mixed feelings on this to be honest.
On one hand is it nice that you want to add hover support, but on the other hand do I feel like this may not be as good in terms of performance...
There was a problem hiding this comment.
Sorry, it does indeed have performance issues; perhaps it's an immature submission. I hope this PR can remain open for others to see, maybe there are better approaches from others.
src/main/java/eu/decentsoftware/holograms/api/listeners/PlayerListener.java
Show resolved
Hide resolved
| if(chunkListMap.isEmpty()) ref(); | ||
|
|
||
| if((System.currentTimeMillis()-orDefault) >= 200L){ | ||
| Optional.ofNullable(chunkListMap.get(player.getLocation().getChunk())).ifPresent(list->{ |
There was a problem hiding this comment.
I don't think the use of Optionals is needed here. A simple getting and later null check does the same.
src/main/java/eu/decentsoftware/holograms/api/listeners/PlayerListener.java
Show resolved
Hide resolved
| Optional.ofNullable(chunkListMap.get(player.getLocation().getChunk())).ifPresent(list->{ | ||
| List<Hologram> holograms = list.stream().collect(Collectors.toList()); | ||
| Vector playerDirection = player.getEyeLocation().getDirection(); | ||
| double threshold = 0.2; // 0.2弧度 |
There was a problem hiding this comment.
As with other comment, use english.
src/main/java/eu/decentsoftware/holograms/api/listeners/PlayerListener.java
Show resolved
Hide resolved
| Hologram fromHologram = decentHolograms.getHologramManager().getHologram(currentViewHd); | ||
| List<Integer> clickableEntityIds = fromHologram.getPage(player).getClickableEntityIds(); | ||
| if(clickableEntityIds.size()>0){ | ||
| fromHologram.onClick(player,clickableEntityIds.get(0),ClickType.HOVER_LEAVE); |
There was a problem hiding this comment.
It would be better to have dedicated onHover methods.
Maybe with a boolean to set whether they look on it or not (i.e. onHover(id, boolean)). The click type feels wrong here.
src/main/java/eu/decentsoftware/holograms/api/listeners/PlayerListener.java
Show resolved
Hide resolved
| Hologram fromHologram = decentHolograms.getHologramManager().getHologram(currentViewHd); | ||
| List<Integer> clickableEntityIds = fromHologram.getPage(player).getClickableEntityIds(); | ||
| if(clickableEntityIds.size()>0){ | ||
| fromHologram.onClick(player,clickableEntityIds.get(0),ClickType.HOVER_LEAVE); |
src/main/java/eu/decentsoftware/holograms/event/DecentHologramsRegisterEvent.java
Show resolved
Hide resolved
src/main/java/eu/decentsoftware/holograms/event/DecentHologramsRegisterEvent.java
Show resolved
Hide resolved
Added actions HOVER (when the mouse hovers over the hologram), HOVER_LEAVE (when the mouse leaves the hologram)