Fallback on "invalid" with missing translation

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 22.1.1 / 2023-10-08
+
+* [BUGFIX] Fix a bug with missing translations ([#920](https://github.com/DavyJonesLocker/client_side_validations/issues/920))
+
 ## 22.1.0 / 2023-10-05
 
 * [FEATURE] Rails 7.1 compatibility

lib/client_side_validations/active_model.rb

@@ -18,7 +18,24 @@ def copy_conditional_attributes(attribute_to, attribute_from)
       private
 
       def build_client_side_hash(model, attribute, options)
-        { message: model.errors.generate_message(attribute, message_type, options) }.merge(options.except(*callbacks_options - %i[allow_blank if unless]))
+        # Rails mutates `options` object when calling `model.errors.generate_message`
+        # by removing `message` option, if any.
+        # By raising on missing translations, CSV has the same behavior across
+        # all supported Rails versions and `config.i18n.raise_on_missing_translations`
+        # possible configurations.
+        options[:raise] = true
+
+        message =
+          begin
+            model.errors.generate_message(attribute, message_type, options)
+          rescue I18n::MissingTranslationData
+            options[:message] = :invalid
+            model.errors.generate_message(attribute, message_type, options)
+          end
+
+        options.delete(:raise)
+
+        { message: message }.merge(options.except(*callbacks_options - %i[allow_blank if unless]))
       end
 
       def message_type

lib/client_side_validations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ClientSideValidations
-  VERSION = '22.1.0'
+  VERSION = '22.1.1'
 end

test/active_model/cases/test_validations.rb

@@ -484,6 +484,20 @@ def test_multiple_validators_of_same_type_on_same_attribute
       assert_equal expected_hash, person.client_side_validation_hash
     end
 
+    def test_missing_translation
+      person = new_person do |p|
+        p.validates :first_name, custom_validation: true
+      end
+
+      expected_hash = {
+        first_name: {
+          custom_validation: [{ message: 'is invalid' }]
+        }
+      }
+
+      assert_equal expected_hash, person.client_side_validation_hash
+    end
+
     def test_ignored_procs_validators
       person = new_person do |p|
         p.validates :first_name, format: proc { |o| o.matcher }

test/base_helper.rb

@@ -50,4 +50,12 @@ class Application < Rails::Application
 
 Rails.application.initialize!
 
+class CustomValidationValidator < ActiveModel::EachValidator
+  def validate_each(record, attribute, value)
+    return if value.blank?
+
+    record.errors.add(attribute, :invalid, **options)
+  end
+end
+
 module ClientSideValidations; end