Change custom_emoji_id Type to string in setEmojiStatus #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Fix: Change
custom_emoji_idType to string in setEmojiStatus🎯 This pull request changes the type of
custom_emoji_idin the setEmojiStatus method from number to string to handle largecustom_emoji_idvalues without precision loss.📚 The
custom_emoji_idvalues, such as 5373141891321699086, are too large to be accurately represented as JavaScript numbers due to the 64-bit floating-point representation, which can lead to precision issues. By changing the type to string, we ensure thatcustom_emoji_idvalues are accurately passed to thesetEmojiStatusmethod without losing precision.