Role idempotency, lots of small changes #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stemd unit files for Debian/Ubuntu (tested on Ubuntu 20.04). For systemd based services the PIDfile directory will not be created anymore, it will be created automatically by systemd via the 'RuntimeDirectory' setting. Added a couple of configuration settings to the systemd unit file which were copied from the unit file which is installed on Ubuntu via the official repository (which is currently at major version 5 of redis, maybe other settings might be better for version 6 - nevertheless the service seems to work).
…updated checksums' (PR 202) from https://github.com/marcobellaccini/ansible-redis # Conflicts: # .travis.yml # README.md # meta/main.yml # tasks/dependencies.yml # tasks/install.yml # tasks/sentinel.yml # tasks/server.yml # vars/main.yml
- Configuration creation and updates are handled via lineinfile such that we do not interfere with changes written by the server/sentinel processes. Additionally master/replica information is sourced dynamically (see runtime_facts.yml) such that we don't force role changes when re-running the playbook. - Added support for "sentinel announce-ip" option (setting "redis_sentinel_announce_ip" to true will result in the "ansible_default_ipv4.address" being used. - Installing a different redis version will lead to a rolling restart of all servers/sentinels. - Minimal support for removing nodes (see README.md)
|
I have start to review your changes, thanks a lot for your work.
|
…handling for including sentinel_reset.yml
|
Great that you are reviewing the changes. I have added |
|
I have done other tests.
|
|
Thank you for further looking into the PR. Unfortunately I will most likely not be able to spend time on this in the foreseeable future. So if you would like to pick up where I left the PR, just go ahead. Otherwise I might get back to it someday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this change is too large to be merged ... but nevertheless (and at least it might be of help for anyone who still hopes for a fix of #22):
It's based on #202, and #128 and may fix #22.
Configuration file management is done via
lineinfileand the role of a node is dynamically updated, i.e. when a fail-over or switch-over has happened it will use the new values forreplicaofandsentinel monitoroptions.Btw.
slavewas changed toreplicaall over the place and as such Redis v5 might be the minimal supported version ...I have tested these changes on Ubuntu 20.04 and Ansible 2.9.12 (so maybe min ansible version might need to be increased in
meta/main.yml).