Change picker to Finder for import when running on macOS #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not use the new picker because it strips EXIF information - Do not request Storage permission, because its unnecessary with file Intent on newer Android versions
| @@ -459,56 +470,99 @@ - (NSData*)processImage:(UIImage*)image info:(NSDictionary*)info options:(CDVPic | |||
| return data; | |||
| } | |||
|
|
|||
| - (void)picker:(PHPickerViewController *)picker didFinishPicking:(NSArray<PHPickerResult *> *)results API_AVAILABLE(ios(14)) { | |||
| - (void)documentPicker:(UIDocumentPickerViewController *)controller | |||
| didPickDocumentsAtURLs:(NSArray<NSURL *> *)urls; { | |||
| __weak CDVCamera* weakSelf = self; | |||
| [self sendErrorResultWithMessage]; | ||
| } | ||
|
|
||
| - (void)sendErrorResultWithMessage { |
There was a problem hiding this comment.
This does more than the naming implies. More like onEndSelectionWithoutImage. And use it also in other instances (e.g. insisde picker:didFinishPicking:)
|
|
||
| - (void)handleImageFromPicker:(UIImage *)original withData:(NSData *)data { | ||
|
|
||
| __weak CDVCamera* weakSelf = self; |
There was a problem hiding this comment.
Weak reference is unncessary at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on macOS as an emulated iOS app we can use the Finder for picking image.
Till now the user could only chose from images in Apple Photos.
Now the user can chose from the whole filesystem. (But only files with image extension)