Skip to content

Commit

Permalink
💚(projet) fix ci error handling
Browse files Browse the repository at this point in the history
CI execution used to stop right after a git lint error so we made these
changes to allow full CI execution
  • Loading branch information
Arame22 committed Jul 19, 2024
1 parent c8c4cdf commit a28556b
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,15 @@ jobs:
run: ~/.local/bin/gitlint --commits origin/main..HEAD

- name: Setup PHP ${{ matrix.php }}
if: ${{ !cancelled() }}
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
ini-values: max_input_vars=5000
coverage: xdebug

- name: Initialise moodle-plugin-ci
if: ${{ !cancelled() }}
run: |
composer create-project -n --no-dev --prefer-dist moodlehq/moodle-plugin-ci ci ^4
echo $(cd ci/bin; pwd) >> $GITHUB_PATH
Expand All @@ -62,6 +64,7 @@ jobs:
echo "NVM_DIR=$HOME/.nvm" >> $GITHUB_ENV
- name: Install moodle-plugin-ci
if: ${{ !cancelled() }}
run: moodle-plugin-ci install --plugin ./plugin --db-host=127.0.0.1
env:
DB: ${{ matrix.database }}
Expand Down
2 changes: 1 addition & 1 deletion block_iagora.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function get_content() {
}

/**
* Defines in which pages this block can be added.
* Define in which pages this block can be added.
*
* @return array of the pages where the block can be added.
*/
Expand Down
2 changes: 1 addition & 1 deletion edit_form.php
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ protected function specific_definition($mform) {
$mform->setType('config_iframeurl', PARAM_URL);
$mform->addHelpButton('config_iframeurl', 'iframeurl', 'block_iagora');
$mform->setDefault('config_iframeurl', '');
$mform->addElement('static', 'iframe_url_desc', '', get_string('iframe_url_desc', 'block_iagora'));
$mform->addElement('static', 'iframeurl_desc', '', get_string('iframeurl_desc', 'block_iagora'));

}

Expand Down
2 changes: 1 addition & 1 deletion lang/en/block_iagora.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/

$string['iframe_url_desc'] = 'Public URL available for chat iframe';
$string['iframeurl'] = 'Iframe URL';
$string['iframeurl_desc'] = 'Public URL available for chat iframe';
$string['iframeurl_help'] = 'Public URL for the Microsoft Copilot chat iframe';
$string['noiframeurl'] = 'No url defined for this block. Please configure a URL in the block parameters';
$string['pluginname'] = 'IAGORA';

0 comments on commit a28556b

Please sign in to comment.