[Bug-4080][Core]Bug fix 4 trigger save point #4105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aiwenmo,
gaoyan1998,
zackyoungh and
Zzm0809
3 tasks
|
昨天遇到相同的 bug, #4108 |
|
Thanks for your solution. @MactavishCui @chenlb |
My pleasure, and I'll keep working on contributing to other issues |
|
增加 PR 时没来找 @MactavishCui 的 PR (先修复了) 。 bug list 列表也没有细找。如果我找详细点，我就不需要增加 PR 了。 |
It's okay. Welcome to contribute to Dinky together! |
Thank you for your attention and contribution. By merging your PR, we expect that we can continue to build Dinky together for mutual benefit and win-win results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
#4080
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Before:
After: