Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all AWS SDK modules to the latest version due to AWS breaking semver #448

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

christophetd
Copy link
Contributor

@christophetd christophetd commented Dec 4, 2023

image

caused by AWS not honoring Semver, and pushing breaking changes (c.f. aws/aws-sdk-go-v2#2370)

It appears that due to the breaking changes around middleware reordering, service client modules tagged on or after yesterday are now fundamentally incompatible with runtime modules tagged before yesterday (and vice versa).

and

As for a post-mortem, this is clearly an unfortunate side-effect of the breaking change that went in on 11/15. In reality I suspect we have a host of undocumented compatibility breaks across our release history. Something as simple as an API added in one module to be consumed by another technically constitutes a break in this way, aws/aws-sdk-go-v2#2372 is an example of this. Even though our release tooling handles updating our own module dependencies, people are free to pin to their own versions and run into breaks like this.

A true semantic versioning system would help mitigate this if not prevent it outright, but that's not something we have in place at this time.

@christophetd christophetd merged commit e936adc into main Dec 4, 2023
5 checks passed
@christophetd christophetd deleted the fix-aws-broken-semver-handling branch December 4, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant