-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dynamically load injector configuration #393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
force-pushed
the
romain.marcadier/APPSEC-55160/dynaspects
branch
3 times, most recently
from
November 14, 2024 11:39
1d20b92
to
2449d71
Compare
RomainMuller
force-pushed
the
romain.marcadier/APPSEC-55160/fingerprinter
branch
from
November 18, 2024 14:49
5fb209e
to
1e099e3
Compare
Base automatically changed from
romain.marcadier/APPSEC-55160/fingerprinter
to
main
November 18, 2024 16:49
RomainMuller
force-pushed
the
romain.marcadier/APPSEC-55160/dynaspects
branch
2 times, most recently
from
November 19, 2024 15:41
1af3065
to
1d20b92
Compare
Use the `config.Loader` to dynamically load the injector configuration everywhere, and not just in `orchestrion pin`.
RomainMuller
force-pushed
the
romain.marcadier/APPSEC-55160/dynaspects
branch
from
November 19, 2024 15:53
1d20b92
to
ddd9825
Compare
RomainMuller
force-pushed
the
romain.marcadier/APPSEC-55160/dynaspects
branch
from
November 19, 2024 16:10
6ee363c
to
5854585
Compare
eliottness
reviewed
Nov 19, 2024
eliottness
approved these changes
Nov 21, 2024
…EC-55160/dynaspects # Conflicts: # internal/injector/builtin/generated.go # internal/injector/builtin/generator/schema.go
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Nov 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Nov 21, 2024
RomainMuller
commented
Nov 22, 2024
@@ -135,7 +135,6 @@ require ( | |||
github.com/cncf/xds/go v0.0.0-20240905190251-b4127c9b8d78 // indirect | |||
github.com/cpuguy83/go-md2man/v2 v2.0.5 // indirect | |||
github.com/dave/dst v0.27.3 // indirect | |||
github.com/dave/jennifer v1.7.1 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
- Coverage 64.23% 63.91% -0.33%
==========================================
Files 185 185
Lines 11087 10912 -175
==========================================
- Hits 7122 6974 -148
+ Misses 3420 3416 -4
+ Partials 545 522 -23
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
config.Loader
to dynamically load the injector configurationeverywhere, and not just in
orchestrion pin
.