Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamically load injector configuration #393

Merged
merged 9 commits into from
Nov 22, 2024

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Nov 14, 2024

Use the config.Loader to dynamically load the injector configuration
everywhere, and not just in orchestrion pin.

@RomainMuller RomainMuller requested a review from a team as a code owner November 14, 2024 11:31
@RomainMuller RomainMuller self-assigned this Nov 14, 2024
@RomainMuller RomainMuller force-pushed the romain.marcadier/APPSEC-55160/dynaspects branch 3 times, most recently from 1d20b92 to 2449d71 Compare November 14, 2024 11:39
@RomainMuller RomainMuller force-pushed the romain.marcadier/APPSEC-55160/fingerprinter branch from 5fb209e to 1e099e3 Compare November 18, 2024 14:49
Base automatically changed from romain.marcadier/APPSEC-55160/fingerprinter to main November 18, 2024 16:49
@RomainMuller RomainMuller marked this pull request as draft November 19, 2024 15:38
@RomainMuller RomainMuller marked this pull request as ready for review November 19, 2024 15:38
@RomainMuller RomainMuller force-pushed the romain.marcadier/APPSEC-55160/dynaspects branch 2 times, most recently from 1af3065 to 1d20b92 Compare November 19, 2024 15:41
Use the `config.Loader` to dynamically load the injector configuration
everywhere, and not just in `orchestrion pin`.
@RomainMuller RomainMuller force-pushed the romain.marcadier/APPSEC-55160/dynaspects branch from 1d20b92 to ddd9825 Compare November 19, 2024 15:53
@RomainMuller RomainMuller force-pushed the romain.marcadier/APPSEC-55160/dynaspects branch from 6ee363c to 5854585 Compare November 19, 2024 16:10
internal/toolexec/aspect/oncompile.go Outdated Show resolved Hide resolved
samples/go.mod Show resolved Hide resolved
internal/injector/builtin/generator/doc.tmpl Show resolved Hide resolved
…EC-55160/dynaspects

# Conflicts:
#	internal/injector/builtin/generated.go
#	internal/injector/builtin/generator/schema.go
@RomainMuller RomainMuller added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 21, 2024
@RomainMuller RomainMuller added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 21, 2024
@@ -135,7 +135,6 @@ require (
github.com/cncf/xds/go v0.0.0-20240905190251-b4127c9b8d78 // indirect
github.com/cpuguy83/go-md2man/v2 v2.0.5 // indirect
github.com/dave/dst v0.27.3 // indirect
github.com/dave/jennifer v1.7.1 // indirect
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eliottness eliottness added this pull request to the merge queue Nov 22, 2024
@RomainMuller RomainMuller merged commit 1d4dcf0 into main Nov 22, 2024
38 checks passed
@RomainMuller RomainMuller deleted the romain.marcadier/APPSEC-55160/dynaspects branch November 22, 2024 15:17
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 71.11111% with 26 lines in your changes missing coverage. Please review.

Project coverage is 63.91%. Comparing base (a8237ee) to head (fc18c44).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/injector/builtin/generator/main.go 53.33% 7 Missing and 7 partials ⚠️
internal/jobserver/buildid/version.go 76.31% 4 Missing and 5 partials ⚠️
internal/toolexec/aspect/oncompile.go 71.42% 1 Missing and 1 partial ⚠️
internal/injector/config/validate.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   64.23%   63.91%   -0.33%     
==========================================
  Files         185      185              
  Lines       11087    10912     -175     
==========================================
- Hits         7122     6974     -148     
+ Misses       3420     3416       -4     
+ Partials      545      522      -23     
Components Coverage Δ
Generators 76.69% <54.83%> (-1.43%) ⬇️
Instruments 73.41% <ø> (ø)
Go Driver 80.16% <ø> (ø)
Toolexec Driver 73.81% <71.42%> (-0.20%) ⬇️
Aspects 78.57% <100.00%> (+4.47%) ⬆️
Injector 77.13% <66.66%> (+2.16%) ⬆️
Job Server 67.99% <76.31%> (-5.47%) ⬇️
Integration Test Suite 57.14% <ø> (ø)
Other 63.91% <71.11%> (-0.33%) ⬇️
Files with missing lines Coverage Δ
internal/injector/aspect/advice/assign.go 75.00% <ø> (+5.76%) ⬆️
internal/injector/aspect/advice/block.go 76.00% <ø> (+5.62%) ⬆️
internal/injector/aspect/advice/call.go 82.90% <ø> (+2.10%) ⬆️
internal/injector/aspect/advice/code/template.go 83.83% <ø> (+1.07%) ⬆️
internal/injector/aspect/advice/import.go 86.66% <ø> (+10.19%) ⬆️
internal/injector/aspect/advice/inject.go 80.00% <ø> (+6.31%) ⬆️
internal/injector/aspect/advice/struct.go 69.69% <ø> (+3.98%) ⬆️
internal/injector/aspect/advice/wrap.go 80.64% <ø> (+4.88%) ⬆️
internal/injector/aspect/aspect.go 71.66% <100.00%> (+15.52%) ⬆️
internal/injector/aspect/join/all-of.go 85.18% <ø> (+8.04%) ⬆️
... and 16 more

... and 3 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants