Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support julienschmidt/httprouter #332

Merged

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Oct 10, 2024

Adds support for github.com/julienschmidt/httprouter

Requires DataDog/dd-trace-go#2921

@rarguelloF rarguelloF changed the title WIP: feat: support julienschmidt/httprouter feat: support julienschmidt/httprouter Oct 17, 2024
@rarguelloF rarguelloF marked this pull request as ready for review October 18, 2024 15:09
@rarguelloF rarguelloF requested a review from a team as a code owner October 18, 2024 15:09
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Ship only once it refers to a tagged release of dd-trace-go.

@rarguelloF rarguelloF added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit c91c3e9 Nov 5, 2024
23 checks passed
@rarguelloF rarguelloF deleted the rarguellof/APPSEC-55047/support-julienschmidt-httprouter branch November 5, 2024 16:51
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@3e4604d). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage        ?   60.28%           
=======================================
  Files           ?      166           
  Lines           ?    11973           
  Branches        ?        0           
=======================================
  Hits            ?     7218           
  Misses          ?     4280           
  Partials        ?      475           
Components Coverage Δ
Generators 76.98% <ø> (?)
Instruments 88.05% <ø> (?)
Go Driver 73.13% <ø> (?)
Toolexec Driver 70.64% <ø> (?)
Aspects 71.73% <ø> (?)
Injector 73.72% <ø> (?)
Job Server 63.45% <ø> (?)
Integration Test Suite 53.55% <100.00%> (?)
Other 60.28% <100.00%> (?)
Files with missing lines Coverage Δ
...lienschmidt_httprouter/julienschmidt_httprouter.go 100.00% <100.00%> (ø)
_integration-tests/tests/mux/mux.go 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants