-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support julienschmidt/httprouter #332
Merged
rarguelloF
merged 7 commits into
main
from
rarguellof/APPSEC-55047/support-julienschmidt-httprouter
Nov 5, 2024
Merged
feat: support julienschmidt/httprouter #332
rarguelloF
merged 7 commits into
main
from
rarguellof/APPSEC-55047/support-julienschmidt-httprouter
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_integration-tests/tests/julienschmidt_httprouter/julienschmidt_httprouter.go
Show resolved
Hide resolved
rarguelloF
changed the title
WIP: feat: support julienschmidt/httprouter
feat: support julienschmidt/httprouter
Oct 17, 2024
RomainMuller
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; Ship only once it refers to a tagged release of dd-trace-go
.
rarguelloF
deleted the
rarguellof/APPSEC-55047/support-julienschmidt-httprouter
branch
November 5, 2024 16:51
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
=======================================
Coverage ? 60.28%
=======================================
Files ? 166
Lines ? 11973
Branches ? 0
=======================================
Hits ? 7218
Misses ? 4280
Partials ? 475
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
github.com/julienschmidt/httprouter
Requires DataDog/dd-trace-go#2921