-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache entry span code origin information to avoid unnecessary repeated stack walks. #8029
base: master
Are you sure you want to change the base?
Conversation
…rate entry span information cache that information and reuse it on commit()
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Debugger benchmarksParameters
See matching parameters
SummaryFound 1 performance improvements and 5 performance regressions! Performance is the same for 2 metrics, 7 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (322.835 µs) : 268, 377
. : milestone, 323,
basic (312.133 µs) : 302, 322
. : milestone, 312,
loop (10.368 ms) : 10340, 10396
. : milestone, 10368,
section candidate
noprobe (312.286 µs) : 269, 355
. : milestone, 312,
basic (305.49 µs) : 294, 317
. : milestone, 305,
loop (11.025 ms) : 10991, 11059
. : milestone, 11025,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~dce86b32b8, baseline=1.44.0-SNAPSHOT~207f770623
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.097 s) : 0, 1097071
Total [baseline] (8.691 s) : 0, 8690875
Agent [candidate] (1.1 s) : 0, 1099926
Total [candidate] (8.704 s) : 0, 8703569
section iast
Agent [baseline] (1.227 s) : 0, 1227082
Total [baseline] (9.251 s) : 0, 9250958
Agent [candidate] (1.217 s) : 0, 1216617
Total [candidate] (9.217 s) : 0, 9217445
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.223 s) : 0, 1222772
Total [baseline] (9.168 s) : 0, 9168157
Agent [candidate] (1.224 s) : 0, 1223997
Total [candidate] (9.211 s) : 0, 9210552
section iast_TELEMETRY_OFF
Agent [baseline] (1.217 s) : 0, 1217330
Total [baseline] (9.186 s) : 0, 9185655
Agent [candidate] (1.214 s) : 0, 1213965
Total [candidate] (9.183 s) : 0, 9183074
gantt
title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~dce86b32b8, baseline=1.44.0-SNAPSHOT~207f770623
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (699.327 ms) : 0, 699327
BytebuddyAgent [candidate] (700.289 ms) : 0, 700289
GlobalTracer [baseline] (319.529 ms) : 0, 319529
GlobalTracer [candidate] (319.724 ms) : 0, 319724
AppSec [baseline] (55.126 ms) : 0, 55126
AppSec [candidate] (54.8 ms) : 0, 54800
Remote Config [baseline] (681.889 µs) : 0, 682
Remote Config [candidate] (685.664 µs) : 0, 686
Telemetry [baseline] (8.606 ms) : 0, 8606
Telemetry [candidate] (10.621 ms) : 0, 10621
section iast
BytebuddyAgent [baseline] (818.16 ms) : 0, 818160
BytebuddyAgent [candidate] (811.233 ms) : 0, 811233
GlobalTracer [baseline] (307.891 ms) : 0, 307891
GlobalTracer [candidate] (305.35 ms) : 0, 305350
AppSec [baseline] (58.288 ms) : 0, 58288
AppSec [candidate] (56.629 ms) : 0, 56629
Remote Config [baseline] (636.639 µs) : 0, 637
Remote Config [candidate] (642.922 µs) : 0, 643
Telemetry [baseline] (7.485 ms) : 0, 7485
Telemetry [candidate] (7.489 ms) : 0, 7489
IAST [baseline] (20.784 ms) : 0, 20784
IAST [candidate] (21.592 ms) : 0, 21592
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (814.16 ms) : 0, 814160
BytebuddyAgent [candidate] (816.807 ms) : 0, 816807
GlobalTracer [baseline] (308.339 ms) : 0, 308339
GlobalTracer [candidate] (306.272 ms) : 0, 306272
AppSec [baseline] (57.632 ms) : 0, 57632
AppSec [candidate] (56.185 ms) : 0, 56185
Remote Config [baseline] (634.566 µs) : 0, 635
Remote Config [candidate] (653.252 µs) : 0, 653
Telemetry [baseline] (7.466 ms) : 0, 7466
Telemetry [candidate] (7.588 ms) : 0, 7588
IAST [baseline] (20.817 ms) : 0, 20817
IAST [candidate] (22.671 ms) : 0, 22671
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (810.265 ms) : 0, 810265
BytebuddyAgent [candidate] (807.921 ms) : 0, 807921
GlobalTracer [baseline] (306.64 ms) : 0, 306640
GlobalTracer [candidate] (305.846 ms) : 0, 305846
AppSec [baseline] (57.556 ms) : 0, 57556
AppSec [candidate] (57.893 ms) : 0, 57893
Remote Config [baseline] (617.124 µs) : 0, 617
Remote Config [candidate] (615.241 µs) : 0, 615
Telemetry [baseline] (7.409 ms) : 0, 7409
Telemetry [candidate] (7.475 ms) : 0, 7475
IAST [baseline] (21.129 ms) : 0, 21129
IAST [candidate] (20.513 ms) : 0, 20513
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~dce86b32b8, baseline=1.44.0-SNAPSHOT~207f770623
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1093953
Total [baseline] (10.411 s) : 0, 10410644
Agent [candidate] (1.092 s) : 0, 1091508
Total [candidate] (10.414 s) : 0, 10414047
section appsec
Agent [baseline] (1.224 s) : 0, 1223956
Total [baseline] (10.779 s) : 0, 10778861
Agent [candidate] (1.232 s) : 0, 1232071
Total [candidate] (10.745 s) : 0, 10744832
section iast
Agent [baseline] (1.215 s) : 0, 1215474
Total [baseline] (10.916 s) : 0, 10916046
Agent [candidate] (1.22 s) : 0, 1220366
Total [candidate] (10.955 s) : 0, 10955188
section profiling
Agent [baseline] (1.312 s) : 0, 1312223
Total [baseline] (10.793 s) : 0, 10793257
Agent [candidate] (1.314 s) : 0, 1314323
Total [candidate] (10.776 s) : 0, 10776388
gantt
title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~dce86b32b8, baseline=1.44.0-SNAPSHOT~207f770623
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.798 ms) : 0, 696798
BytebuddyAgent [candidate] (694.083 ms) : 0, 694083
GlobalTracer [baseline] (317.132 ms) : 0, 317132
GlobalTracer [candidate] (317.287 ms) : 0, 317287
AppSec [baseline] (54.993 ms) : 0, 54993
AppSec [candidate] (55.064 ms) : 0, 55064
Remote Config [baseline] (679.777 µs) : 0, 680
Remote Config [candidate] (670.093 µs) : 0, 670
Telemetry [baseline] (10.61 ms) : 0, 10610
Telemetry [candidate] (10.694 ms) : 0, 10694
section appsec
BytebuddyAgent [baseline] (710.583 ms) : 0, 710583
BytebuddyAgent [candidate] (714.393 ms) : 0, 714393
GlobalTracer [baseline] (314.347 ms) : 0, 314347
GlobalTracer [candidate] (316.76 ms) : 0, 316760
AppSec [baseline] (167.863 ms) : 0, 167863
AppSec [candidate] (168.264 ms) : 0, 168264
Remote Config [baseline] (643.182 µs) : 0, 643
Remote Config [candidate] (656.49 µs) : 0, 656
Telemetry [baseline] (7.412 ms) : 0, 7412
Telemetry [candidate] (8.525 ms) : 0, 8525
IAST [baseline] (18.901 ms) : 0, 18901
IAST [candidate] (19.398 ms) : 0, 19398
section iast
BytebuddyAgent [baseline] (810.037 ms) : 0, 810037
BytebuddyAgent [candidate] (812.721 ms) : 0, 812721
GlobalTracer [baseline] (305.177 ms) : 0, 305177
GlobalTracer [candidate] (306.875 ms) : 0, 306875
AppSec [baseline] (57.838 ms) : 0, 57838
AppSec [candidate] (57.919 ms) : 0, 57919
Remote Config [baseline] (625.504 µs) : 0, 626
Remote Config [candidate] (645.767 µs) : 0, 646
Telemetry [baseline] (7.468 ms) : 0, 7468
Telemetry [candidate] (7.573 ms) : 0, 7573
IAST [baseline] (20.697 ms) : 0, 20697
IAST [candidate] (20.906 ms) : 0, 20906
section profiling
BytebuddyAgent [baseline] (687.066 ms) : 0, 687066
BytebuddyAgent [candidate] (687.329 ms) : 0, 687329
GlobalTracer [baseline] (430.883 ms) : 0, 430883
GlobalTracer [candidate] (433.246 ms) : 0, 433246
AppSec [baseline] (53.683 ms) : 0, 53683
AppSec [candidate] (53.581 ms) : 0, 53581
Remote Config [baseline] (653.8 µs) : 0, 654
Remote Config [candidate] (658.552 µs) : 0, 659
Telemetry [baseline] (7.692 ms) : 0, 7692
Telemetry [candidate] (7.707 ms) : 0, 7707
ProfilingAgent [baseline] (93.263 ms) : 0, 93263
ProfilingAgent [candidate] (92.723 ms) : 0, 92723
Profiling [baseline] (93.288 ms) : 0, 93288
Profiling [candidate] (92.746 ms) : 0, 92746
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~dce86b32b8, baseline=1.44.0-SNAPSHOT~207f770623
dateFormat X
axisFormat %s
section baseline
no_agent (377.53 µs) : 357, 398
. : milestone, 378,
iast (486.174 µs) : 465, 508
. : milestone, 486,
iast_FULL (646.51 µs) : 625, 668
. : milestone, 647,
iast_GLOBAL (512.728 µs) : 491, 534
. : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (485.354 µs) : 464, 507
. : milestone, 485,
iast_INACTIVE (446.102 µs) : 425, 467
. : milestone, 446,
iast_TELEMETRY_OFF (484.939 µs) : 463, 507
. : milestone, 485,
tracing (448.009 µs) : 427, 469
. : milestone, 448,
section candidate
no_agent (372.601 µs) : 353, 392
. : milestone, 373,
iast (486.934 µs) : 465, 509
. : milestone, 487,
iast_FULL (644.839 µs) : 623, 666
. : milestone, 645,
iast_GLOBAL (515.228 µs) : 493, 537
. : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (487.385 µs) : 466, 509
. : milestone, 487,
iast_INACTIVE (446.23 µs) : 425, 467
. : milestone, 446,
iast_TELEMETRY_OFF (477.899 µs) : 457, 499
. : milestone, 478,
tracing (448.353 µs) : 426, 470
. : milestone, 448,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~dce86b32b8, baseline=1.44.0-SNAPSHOT~207f770623
dateFormat X
axisFormat %s
section baseline
no_agent (1.365 ms) : 1345, 1384
. : milestone, 1365,
appsec (1.748 ms) : 1723, 1773
. : milestone, 1748,
appsec_no_iast (1.739 ms) : 1714, 1763
. : milestone, 1739,
iast (1.485 ms) : 1462, 1507
. : milestone, 1485,
profiling (1.515 ms) : 1492, 1539
. : milestone, 1515,
tracing (1.483 ms) : 1459, 1508
. : milestone, 1483,
section candidate
no_agent (1.349 ms) : 1330, 1369
. : milestone, 1349,
appsec (1.739 ms) : 1715, 1763
. : milestone, 1739,
appsec_no_iast (1.717 ms) : 1691, 1743
. : milestone, 1717,
iast (1.487 ms) : 1464, 1510
. : milestone, 1487,
profiling (1.518 ms) : 1492, 1543
. : milestone, 1518,
tracing (1.476 ms) : 1452, 1500
. : milestone, 1476,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~dce86b32b8, baseline=1.44.0-SNAPSHOT~207f770623
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.327 ms) : 2286, 2369
. : milestone, 2327,
iast (2.081 ms) : 2029, 2134
. : milestone, 2081,
iast_GLOBAL (2.117 ms) : 2064, 2170
. : milestone, 2117,
profiling (1.935 ms) : 1894, 1977
. : milestone, 1935,
tracing (1.921 ms) : 1881, 1962
. : milestone, 1921,
section candidate
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.335 ms) : 2293, 2376
. : milestone, 2335,
iast (2.08 ms) : 2027, 2133
. : milestone, 2080,
iast_GLOBAL (2.12 ms) : 2067, 2173
. : milestone, 2120,
profiling (1.944 ms) : 1902, 1986
. : milestone, 1944,
tracing (1.92 ms) : 1880, 1960
. : milestone, 1920,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~dce86b32b8, baseline=1.44.0-SNAPSHOT~207f770623
dateFormat X
axisFormat %s
section baseline
no_agent (15.523 s) : 15523000, 15523000
. : milestone, 15523000,
appsec (15.152 s) : 15152000, 15152000
. : milestone, 15152000,
iast (18.672 s) : 18672000, 18672000
. : milestone, 18672000,
iast_GLOBAL (17.681 s) : 17681000, 17681000
. : milestone, 17681000,
profiling (14.738 s) : 14738000, 14738000
. : milestone, 14738000,
tracing (15.097 s) : 15097000, 15097000
. : milestone, 15097000,
section candidate
no_agent (15.474 s) : 15474000, 15474000
. : milestone, 15474000,
appsec (15.159 s) : 15159000, 15159000
. : milestone, 15159000,
iast (18.571 s) : 18571000, 18571000
. : milestone, 18571000,
iast_GLOBAL (17.818 s) : 17818000, 17818000
. : milestone, 17818000,
profiling (15.582 s) : 15582000, 15582000
. : milestone, 15582000,
tracing (14.855 s) : 14855000, 14855000
. : milestone, 14855000,
|
What Does This Do
This PR uses the class parsing during instrumentation to extract out more accurate entry span information
caches that information to reuse it on commit()
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-3159