-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multivalue multiline header extraction for ApacheHttpClient #7996
Draft
sarahchen6
wants to merge
6
commits into
master
Choose a base branch
from
sarahchen6/allow-mulitline-headers-apachehttpclient
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Allow multivalue multiline header extraction for ApacheHttpClient #7996
sarahchen6
wants to merge
6
commits into
master
from
sarahchen6/allow-mulitline-headers-apachehttpclient
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~e15b289582, baseline=1.43.0-SNAPSHOT~c8030bdceb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088037
Total [baseline] (10.455 s) : 0, 10454598
Agent [candidate] (1.091 s) : 0, 1091284
Total [candidate] (10.543 s) : 0, 10542869
section appsec
Agent [baseline] (1.223 s) : 0, 1222625
Total [baseline] (10.811 s) : 0, 10810708
Agent [candidate] (1.229 s) : 0, 1229335
Total [candidate] (10.667 s) : 0, 10666976
section iast
Agent [baseline] (1.217 s) : 0, 1217083
Total [baseline] (10.943 s) : 0, 10943297
Agent [candidate] (1.218 s) : 0, 1218452
Total [candidate] (10.924 s) : 0, 10924263
section profiling
Agent [baseline] (1.318 s) : 0, 1318221
Total [baseline] (10.839 s) : 0, 10839428
Agent [candidate] (1.326 s) : 0, 1326272
Total [candidate] (10.903 s) : 0, 10902724
gantt
title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~e15b289582, baseline=1.43.0-SNAPSHOT~c8030bdceb
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.898 ms) : 0, 690898
BytebuddyAgent [candidate] (693.052 ms) : 0, 693052
GlobalTracer [baseline] (317.624 ms) : 0, 317624
GlobalTracer [candidate] (318.332 ms) : 0, 318332
AppSec [baseline] (54.468 ms) : 0, 54468
AppSec [candidate] (54.859 ms) : 0, 54859
Remote Config [baseline] (680.662 µs) : 0, 681
Remote Config [candidate] (712.227 µs) : 0, 712
Telemetry [baseline] (10.683 ms) : 0, 10683
Telemetry [candidate] (10.625 ms) : 0, 10625
section appsec
BytebuddyAgent [baseline] (708.802 ms) : 0, 708802
BytebuddyAgent [candidate] (713.801 ms) : 0, 713801
GlobalTracer [baseline] (314.549 ms) : 0, 314549
GlobalTracer [candidate] (315.578 ms) : 0, 315578
AppSec [baseline] (166.433 ms) : 0, 166433
AppSec [candidate] (165.957 ms) : 0, 165957
IAST [baseline] (20.457 ms) : 0, 20457
IAST [candidate] (21.05 ms) : 0, 21050
Remote Config [baseline] (639.017 µs) : 0, 639
Remote Config [candidate] (648.032 µs) : 0, 648
Telemetry [baseline] (8.271 ms) : 0, 8271
Telemetry [candidate] (9.015 ms) : 0, 9015
section iast
BytebuddyAgent [baseline] (809.447 ms) : 0, 809447
BytebuddyAgent [candidate] (810.074 ms) : 0, 810074
GlobalTracer [baseline] (307.222 ms) : 0, 307222
GlobalTracer [candidate] (307.27 ms) : 0, 307270
AppSec [baseline] (57.747 ms) : 0, 57747
AppSec [candidate] (56.517 ms) : 0, 56517
IAST [baseline] (20.789 ms) : 0, 20789
IAST [candidate] (22.631 ms) : 0, 22631
Remote Config [baseline] (623.196 µs) : 0, 623
Remote Config [candidate] (612.948 µs) : 0, 613
Telemetry [baseline] (7.52 ms) : 0, 7520
Telemetry [candidate] (7.556 ms) : 0, 7556
section profiling
BytebuddyAgent [baseline] (686.555 ms) : 0, 686555
BytebuddyAgent [candidate] (692.478 ms) : 0, 692478
GlobalTracer [baseline] (436.173 ms) : 0, 436173
GlobalTracer [candidate] (437.746 ms) : 0, 437746
AppSec [baseline] (53.764 ms) : 0, 53764
AppSec [candidate] (53.848 ms) : 0, 53848
Remote Config [baseline] (674.892 µs) : 0, 675
Remote Config [candidate] (665.506 µs) : 0, 666
Telemetry [baseline] (7.814 ms) : 0, 7814
Telemetry [candidate] (7.84 ms) : 0, 7840
ProfilingAgent [baseline] (94.276 ms) : 0, 94276
ProfilingAgent [candidate] (94.188 ms) : 0, 94188
Profiling [baseline] (94.3 ms) : 0, 94300
Profiling [candidate] (94.212 ms) : 0, 94212
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~e15b289582, baseline=1.43.0-SNAPSHOT~c8030bdceb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1089192
Total [baseline] (8.656 s) : 0, 8656307
Agent [candidate] (1.092 s) : 0, 1092020
Total [candidate] (8.684 s) : 0, 8683665
section iast
Agent [baseline] (1.217 s) : 0, 1217151
Total [baseline] (9.194 s) : 0, 9194165
Agent [candidate] (1.217 s) : 0, 1217489
Total [candidate] (9.217 s) : 0, 9217408
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.215 s) : 0, 1215044
Total [baseline] (9.175 s) : 0, 9174551
Agent [candidate] (1.228 s) : 0, 1227675
Total [candidate] (9.179 s) : 0, 9178720
section iast_TELEMETRY_OFF
Agent [baseline] (1.214 s) : 0, 1213671
Total [baseline] (9.198 s) : 0, 9198112
Agent [candidate] (1.213 s) : 0, 1213414
Total [candidate] (9.19 s) : 0, 9190107
gantt
title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~e15b289582, baseline=1.43.0-SNAPSHOT~c8030bdceb
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.305 ms) : 0, 693305
BytebuddyAgent [candidate] (693.809 ms) : 0, 693809
GlobalTracer [baseline] (317.758 ms) : 0, 317758
GlobalTracer [candidate] (318.824 ms) : 0, 318824
AppSec [baseline] (54.491 ms) : 0, 54491
AppSec [candidate] (55.029 ms) : 0, 55029
Remote Config [baseline] (689.287 µs) : 0, 689
Remote Config [candidate] (700.044 µs) : 0, 700
Telemetry [baseline] (9.198 ms) : 0, 9198
Telemetry [candidate] (9.931 ms) : 0, 9931
section iast
BytebuddyAgent [baseline] (809.642 ms) : 0, 809642
BytebuddyAgent [candidate] (809.335 ms) : 0, 809335
GlobalTracer [baseline] (306.956 ms) : 0, 306956
GlobalTracer [candidate] (306.66 ms) : 0, 306660
AppSec [baseline] (57.867 ms) : 0, 57867
AppSec [candidate] (57.607 ms) : 0, 57607
IAST [baseline] (20.778 ms) : 0, 20778
IAST [candidate] (21.954 ms) : 0, 21954
Remote Config [baseline] (605.375 µs) : 0, 605
Remote Config [candidate] (629.184 µs) : 0, 629
Telemetry [baseline] (7.54 ms) : 0, 7540
Telemetry [candidate] (7.573 ms) : 0, 7573
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (807.577 ms) : 0, 807577
BytebuddyAgent [candidate] (816.41 ms) : 0, 816410
GlobalTracer [baseline] (306.679 ms) : 0, 306679
GlobalTracer [candidate] (310.006 ms) : 0, 310006
AppSec [baseline] (56.374 ms) : 0, 56374
AppSec [candidate] (58.163 ms) : 0, 58163
IAST [baseline] (22.551 ms) : 0, 22551
IAST [candidate] (20.989 ms) : 0, 20989
Remote Config [baseline] (619.643 µs) : 0, 620
Remote Config [candidate] (624.045 µs) : 0, 624
Telemetry [baseline] (7.514 ms) : 0, 7514
Telemetry [candidate] (7.637 ms) : 0, 7637
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (805.905 ms) : 0, 805905
BytebuddyAgent [candidate] (805.519 ms) : 0, 805519
GlobalTracer [baseline] (306.705 ms) : 0, 306705
GlobalTracer [candidate] (306.692 ms) : 0, 306692
AppSec [baseline] (58.809 ms) : 0, 58809
AppSec [candidate] (57.858 ms) : 0, 57858
IAST [baseline] (20.366 ms) : 0, 20366
IAST [candidate] (21.445 ms) : 0, 21445
Remote Config [baseline] (616.596 µs) : 0, 617
Remote Config [candidate] (630.781 µs) : 0, 631
Telemetry [baseline] (7.505 ms) : 0, 7505
Telemetry [candidate] (7.513 ms) : 0, 7513
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~e15b289582, baseline=1.43.0-SNAPSHOT~c8030bdceb
dateFormat X
axisFormat %s
section baseline
no_agent (380.306 µs) : 361, 400
. : milestone, 380,
iast (494.222 µs) : 473, 516
. : milestone, 494,
iast_FULL (650.449 µs) : 629, 672
. : milestone, 650,
iast_GLOBAL (519.573 µs) : 498, 541
. : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (506.23 µs) : 485, 528
. : milestone, 506,
iast_INACTIVE (464.527 µs) : 442, 487
. : milestone, 465,
iast_TELEMETRY_OFF (484.235 µs) : 463, 505
. : milestone, 484,
tracing (453.112 µs) : 432, 474
. : milestone, 453,
section candidate
no_agent (381.521 µs) : 360, 403
. : milestone, 382,
iast (496.12 µs) : 475, 518
. : milestone, 496,
iast_FULL (652.936 µs) : 631, 675
. : milestone, 653,
iast_GLOBAL (530.477 µs) : 508, 553
. : milestone, 530,
iast_HARDCODED_SECRET_DISABLED (500.443 µs) : 479, 522
. : milestone, 500,
iast_INACTIVE (464.565 µs) : 443, 486
. : milestone, 465,
iast_TELEMETRY_OFF (486.824 µs) : 466, 508
. : milestone, 487,
tracing (459.409 µs) : 438, 480
. : milestone, 459,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~e15b289582, baseline=1.43.0-SNAPSHOT~c8030bdceb
dateFormat X
axisFormat %s
section baseline
no_agent (1.368 ms) : 1348, 1387
. : milestone, 1368,
appsec (1.756 ms) : 1731, 1781
. : milestone, 1756,
appsec_no_iast (1.782 ms) : 1757, 1807
. : milestone, 1782,
iast (1.505 ms) : 1482, 1529
. : milestone, 1505,
profiling (1.513 ms) : 1491, 1536
. : milestone, 1513,
tracing (1.489 ms) : 1464, 1514
. : milestone, 1489,
section candidate
no_agent (1.364 ms) : 1344, 1385
. : milestone, 1364,
appsec (1.772 ms) : 1747, 1798
. : milestone, 1772,
appsec_no_iast (1.766 ms) : 1742, 1791
. : milestone, 1766,
iast (1.495 ms) : 1472, 1518
. : milestone, 1495,
profiling (1.538 ms) : 1513, 1562
. : milestone, 1538,
tracing (1.498 ms) : 1474, 1522
. : milestone, 1498,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 7 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~e15b289582, baseline=1.43.0-SNAPSHOT~c8030bdceb
dateFormat X
axisFormat %s
section baseline
no_agent (15.267 s) : 15267000, 15267000
. : milestone, 15267000,
appsec (15.157 s) : 15157000, 15157000
. : milestone, 15157000,
iast (18.509 s) : 18509000, 18509000
. : milestone, 18509000,
iast_GLOBAL (18.082 s) : 18082000, 18082000
. : milestone, 18082000,
profiling (14.912 s) : 14912000, 14912000
. : milestone, 14912000,
tracing (15.0 s) : 15000000, 15000000
. : milestone, 15000000,
section candidate
no_agent (15.527 s) : 15527000, 15527000
. : milestone, 15527000,
appsec (15.083 s) : 15083000, 15083000
. : milestone, 15083000,
iast (18.968 s) : 18968000, 18968000
. : milestone, 18968000,
iast_GLOBAL (18.219 s) : 18219000, 18219000
. : milestone, 18219000,
profiling (15.197 s) : 15197000, 15197000
. : milestone, 15197000,
tracing (14.873 s) : 14873000, 14873000
. : milestone, 14873000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~e15b289582, baseline=1.43.0-SNAPSHOT~c8030bdceb
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.335 ms) : 2294, 2376
. : milestone, 2335,
iast (2.086 ms) : 2033, 2138
. : milestone, 2086,
iast_GLOBAL (2.119 ms) : 2067, 2172
. : milestone, 2119,
profiling (1.957 ms) : 1914, 2000
. : milestone, 1957,
tracing (1.92 ms) : 1880, 1960
. : milestone, 1920,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (5.342 ms) : 5286, 5397
. : milestone, 5342,
iast (5.4 ms) : 5336, 5465
. : milestone, 5400,
iast_GLOBAL (5.463 ms) : 5399, 5527
. : milestone, 5463,
profiling (5.524 ms) : 5464, 5584
. : milestone, 5524,
tracing (5.3 ms) : 5245, 5356
. : milestone, 5300,
|
sarahchen6
force-pushed
the
sarahchen6/allow-mulitline-headers-apachehttpclient
branch
from
November 22, 2024 20:55
6b10416
to
d7f1afa
Compare
sarahchen6
changed the title
Allow multvalue multiline header extraction for ApacheHttpClient
Allow multivalue multiline header extraction for ApacheHttpClient
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
WIP split from #7943
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]