Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debugger] Fix system tests CI #7987

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

shurivich
Copy link
Contributor

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@shurivich shurivich added the comp: debugger Dynamic Instrumentation label Nov 20, 2024
@shurivich shurivich self-assigned this Nov 20, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 20, 2024

Benchmarks

Startup

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-11-21T14:09:53 2024-11-21T14:16:49
git_branch master shurivich/debugger_system_tests
git_commit_date 1732196287 1732197558
git_commit_sha cd1b746 3b194aa
release_version 1.43.0-SNAPSHOT~cd1b746d93 1.43.0-SNAPSHOT~3b194aabe2
start_time 2024-11-21T14:09:40 2024-11-21T14:16:36
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1732198962 1732198962
ci_job_id 715361830 715361830
ci_pipeline_id 49605190 49605190
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+57.214µs; +107.504µs] or [+3.835%; +7.205%]
unstable
[-689.412op/s; +461.492op/s] or [-22.406%; +14.998%]
1.574ms 2962.963op/s 1.492ms 3076.923op/s
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~3b194aabe2, baseline=1.43.0-SNAPSHOT~cd1b746d93
    dateFormat X
    axisFormat %s
section baseline
no_agent (373.427 µs) : 353, 393
.   : milestone, 373,
iast (492.732 µs) : 471, 515
.   : milestone, 493,
iast_FULL (645.524 µs) : 624, 667
.   : milestone, 646,
iast_GLOBAL (521.241 µs) : 499, 543
.   : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (487.586 µs) : 467, 509
.   : milestone, 488,
iast_INACTIVE (454.616 µs) : 433, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (477.97 µs) : 457, 499
.   : milestone, 478,
tracing (445.008 µs) : 424, 466
.   : milestone, 445,
section candidate
no_agent (377.009 µs) : 357, 397
.   : milestone, 377,
iast (487.297 µs) : 466, 509
.   : milestone, 487,
iast_FULL (649.59 µs) : 628, 671
.   : milestone, 650,
iast_GLOBAL (511.031 µs) : 490, 532
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (492.405 µs) : 471, 514
.   : milestone, 492,
iast_INACTIVE (459.297 µs) : 437, 482
.   : milestone, 459,
iast_TELEMETRY_OFF (480.373 µs) : 459, 502
.   : milestone, 480,
tracing (443.958 µs) : 423, 465
.   : milestone, 444,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.427 µs [353.371 µs, 393.483 µs] -
iast 492.732 µs [470.944 µs, 514.519 µs] 119.304 µs (31.9%)
iast_FULL 645.524 µs [624.127 µs, 666.921 µs] 272.097 µs (72.9%)
iast_GLOBAL 521.241 µs [499.079 µs, 543.403 µs] 147.813 µs (39.6%)
iast_HARDCODED_SECRET_DISABLED 487.586 µs [466.514 µs, 508.659 µs] 114.159 µs (30.6%)
iast_INACTIVE 454.616 µs [433.165 µs, 476.066 µs] 81.189 µs (21.7%)
iast_TELEMETRY_OFF 477.97 µs [456.747 µs, 499.194 µs] 104.543 µs (28.0%)
tracing 445.008 µs [424.163 µs, 465.853 µs] 71.58 µs (19.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.009 µs [357.188 µs, 396.83 µs] -
iast 487.297 µs [465.837 µs, 508.757 µs] 110.288 µs (29.3%)
iast_FULL 649.59 µs [628.119 µs, 671.061 µs] 272.581 µs (72.3%)
iast_GLOBAL 511.031 µs [489.646 µs, 532.416 µs] 134.022 µs (35.5%)
iast_HARDCODED_SECRET_DISABLED 492.405 µs [470.903 µs, 513.908 µs] 115.397 µs (30.6%)
iast_INACTIVE 459.297 µs [436.594 µs, 482.0 µs] 82.288 µs (21.8%)
iast_TELEMETRY_OFF 480.373 µs [458.678 µs, 502.068 µs] 103.364 µs (27.4%)
tracing 443.958 µs [423.35 µs, 464.565 µs] 66.949 µs (17.8%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~3b194aabe2, baseline=1.43.0-SNAPSHOT~cd1b746d93
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1374
.   : milestone, 1355,
appsec (1.752 ms) : 1728, 1776
.   : milestone, 1752,
appsec_no_iast (1.735 ms) : 1710, 1759
.   : milestone, 1735,
iast (1.493 ms) : 1471, 1515
.   : milestone, 1493,
profiling (1.492 ms) : 1469, 1515
.   : milestone, 1492,
tracing (1.472 ms) : 1447, 1497
.   : milestone, 1472,
section candidate
no_agent (1.346 ms) : 1328, 1365
.   : milestone, 1346,
appsec (1.746 ms) : 1721, 1771
.   : milestone, 1746,
appsec_no_iast (1.736 ms) : 1711, 1760
.   : milestone, 1736,
iast (1.481 ms) : 1458, 1504
.   : milestone, 1481,
profiling (1.574 ms) : 1550, 1598
.   : milestone, 1574,
tracing (1.491 ms) : 1465, 1517
.   : milestone, 1491,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.335 ms, 1.374 ms] -
appsec 1.752 ms [1.728 ms, 1.776 ms] 397.458 µs (29.3%)
appsec_no_iast 1.735 ms [1.71 ms, 1.759 ms] 380.297 µs (28.1%)
iast 1.493 ms [1.471 ms, 1.515 ms] 138.409 µs (10.2%)
profiling 1.492 ms [1.469 ms, 1.515 ms] 137.443 µs (10.1%)
tracing 1.472 ms [1.447 ms, 1.497 ms] 117.229 µs (8.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.328 ms, 1.365 ms] -
appsec 1.746 ms [1.721 ms, 1.771 ms] 399.658 µs (29.7%)
appsec_no_iast 1.736 ms [1.711 ms, 1.76 ms] 389.118 µs (28.9%)
iast 1.481 ms [1.458 ms, 1.504 ms] 134.512 µs (10.0%)
profiling 1.574 ms [1.55 ms, 1.598 ms] 227.947 µs (16.9%)
tracing 1.491 ms [1.465 ms, 1.517 ms] 144.678 µs (10.7%)

Dacapo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant