Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ddtrace/tracer): skip TestTracerOptionsDefaults/dogstatsd #2992

Merged

Conversation

darccio
Copy link
Member

@darccio darccio commented Nov 25, 2024

What does this PR do?

Adds t.Skip to reduce friction for other teams while we fix the underlying issue.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio darccio requested a review from a team as a code owner November 25, 2024 22:01
@darccio darccio merged commit ee8eeef into main Nov 25, 2024
159 of 160 checks passed
@darccio darccio deleted the dario.castane/skip-testtraceroptionsdefaults-dogstatsd branch November 25, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant