Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/civisibility: fix RWMutex usages #2982

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

tonyredondo
Copy link
Member

What does this PR do?

Fix sync.RWMutex usages.

Motivation

It was wrong, the mutex was being used only on read mode.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Nov 19, 2024

Benchmarks

Benchmark execution time: 2024-11-19 00:13:51

Comparing candidate commit c06c65a in PR branch tony/civisibility-fix-locks with baseline commit d7cc13a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics.

@tonyredondo tonyredondo merged commit 58e1e63 into main Nov 19, 2024
160 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-fix-locks branch November 19, 2024 09:28
eliottness pushed a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants