Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/appsec: fix blocking atomicity #2955

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

eliottness
Copy link
Contributor

What does this PR do?

Rework emitter/httpsec.BeforeHandle to make blockAtomic value content atomic itself

Motivation

#2921 (comment)

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness eliottness marked this pull request as ready for review October 30, 2024 09:56
@eliottness eliottness requested a review from a team as a code owner October 30, 2024 09:56
@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2024

Benchmarks

Benchmark execution time: 2024-10-30 10:22:58

Comparing candidate commit 705dbff in PR branch eliott.bouhana/fix-atomic-httpsec-emitter with baseline commit fcda5e2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@RomainMuller RomainMuller merged commit fab2f13 into main Oct 30, 2024
171 checks passed
@RomainMuller RomainMuller deleted the eliott.bouhana/fix-atomic-httpsec-emitter branch October 30, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants