-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: add workflow to update outdated integrations #2936
base: main
Are you sure you want to change the base?
internal: add workflow to update outdated integrations #2936
Conversation
BenchmarksBenchmark execution time: 2024-11-26 17:39:58 Comparing candidate commit 62fd260 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics. |
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
steps: | ||
- uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
- name: Create Pull Request | ||
id: pr | ||
uses: peter-evans/create-pull-request@v6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- run: go run latest_major_version.go > latest_majors.txt | ||
|
||
- name: Create Pull Request | ||
id: pr | ||
uses: peter-evans/create-pull-request@v6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I see for now, you are only outputting a text file with New latest major version
, which I think it doesn't make much sense to be committed to the repo.
What about sending a slack notification for now? We can work on some sort of code-change actionable in the future.
c5418fd
to
df21b8e
Compare
syntax display git diff wip update workflow file Add copyright header to file wip update to use modfile to parse go.mod update workflow file for testing wip Add dummy file for only contribs wip gofmt and lint Cleanup output
a7f4d34
to
1cb4f22
Compare
What does this PR do?
Checks if there is a new latest
major
available for packages. If so, emit a warning that there is a new major available.Usage:
go run latest_major_version.go
emits a list of modules listed ingo.mod
that have a new major version available.Issue to improve on:
<repo>/v<major_version>
but sometimes the maintainers rename the entire module in a new major, ex.oliviere/elastic
: https://github.com/olivere/elastic#releases. We currently only handle the first case.Motivation
Reviewer's Checklist
Unsure? Have a question? Request a review!