contrib/envoyproxy: envoy external processing support #2895
+1,181
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-n-0
force-pushed
the
flavien/service-extensions
branch
7 times, most recently
from
fcbd354
to
a587a09
Compare
BenchmarksBenchmark execution time: 2024-11-28 15:42:06 Comparing candidate commit b0844b8 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics. |
e-n-0
force-pushed
the
flavien/service-extensions
branch
16 times, most recently
from
4134743
to
a96cc2a
Compare
github-actions
bot
added
the
apm:ecosystem
e-n-0
force-pushed
the
flavien/service-extensions
branch
from
2eeb6b1
to
402f7d0
Compare
eliottness
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Thanks for contributing 🙏. Couple of requests:
- Normally you should not have to import any
listenerpackages, nor to export functions from it. - Could you link to a manual CI run from the
System Testsworkflow pointing on your system-tests branch where the workflow run is green ? You probably have to add your scenario in the workflow for it to run - I suspect we need to add tests for the changes you did in the
emitter/waf/actionspackage. Let's see if this would make sense to separate it in another PR - Let's review together the code of
envoy.goon fridayso we can structure it better
e-n-0
force-pushed
the
flavien/service-extensions
branch
from
bdd1915
to
1f2b791
Compare
eliottness
force-pushed
the
flavien/service-extensions
branch
2 times, most recently
from
9630788
to
0929de5
Compare
|
Consolidated system-test run: https://github.com/DataDog/dd-trace-go/actions/runs/11797728094 |
eliottness
reviewed
Nov 12, 2024
Comment on lines
+19
to
+25
| // ResetStatusCode resets the status code of the response writer. | ||
| func ResetStatusCode(w http.ResponseWriter) { | ||
| if rw, ok := w.(*responseWriter); ok { | ||
| rw.status = 0 | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This required because of this if statement.
eliottness
changed the title
eliottness
approved these changes
Nov 12, 2024
eliottness
force-pushed
the
flavien/service-extensions
branch
from
0929de5
to
e3bb1e5
Compare
rarguelloF
requested changes
Nov 15, 2024
contrib/envoyproxy/envoy/envoy.go
Outdated
| // This product includes software developed at Datadog (https://www.datadoghq.com/). | ||
| // Copyright 2016 Datadog, Inc. | ||
|
|
||
| package envoy |
There was a problem hiding this comment.
could you please add an example_test.go file showing how this integration is used with some sort of real world example? 🙏
Signed-off-by: Eliott Bouhana <[email protected]>
* Add support for context propagation * Normalize span tag use Co-authored-by: Flavien Darche <[email protected]> Signed-off-by: Eliott Bouhana <[email protected]>
e-n-0
force-pushed
the
flavien/service-extensions
branch
from
c7063d8
to
b0844b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the part 1 PR to support Envoy's External Processing.
You can find all related document for this implementation in Confluence ASM - GCP Services Extensions.
You can find the part 2 of this PR here.
What does this PR do?
This PR adds a new gRPC Interceptor (
StreamServerInterceptor) to support the interception of ext_proc v3 calls to gRPC server. When the interceptor is applied, all messages of the external processing protocol are instrumented without returning an handle to the original server code. The implementation of a server using this instrumentation can be found in the part 2.The implementation includes:
content-typeandredirect)http.Requestobject.Tests
This PR includes unit testing in the
envoy_tests.go, simulating scenarios of malicious or benign requests, validating span tags, security events and blocking results.System-tests have been implemented on this PR. A new
external-processingscenario has been added in thegolangstage.Reviewer's Checklist
Unsure? Have a question? Request a review!