Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin jaro_winkler version #921

Merged
merged 1 commit into from
Jul 10, 2024
Merged

pin jaro_winkler version #921

merged 1 commit into from
Jul 10, 2024

Conversation

AliDatadog
Copy link
Contributor

What does this PR do?

This PR fixes a dependency issue met with my Mac M1.

Running bundle install resolves jaro_winkler 1.5.4 which doesn't compile

An error occurred while installing jaro_winkler (1.5.4), and Bundler cannot continue.

In Gemfile:
  cookstyle was resolved to 6.1.6, which depends on
    rubocop was resolved to 0.80.1, which depends on
      jaro_winkler

Compile error:

jaro_winkler.c:19:3: error: incompatible function pointer types passing 'VALUE (size_t, VALUE *, VALUE)' (aka 'unsigned long (unsigned long, unsigned long *, unsigned long)') to parameter
of type 'VALUE (*)(int, union (unnamed union at /Users/user/.rbenv/versions/3.1.4/include/ruby-3.1.0/ruby/internal/anyargs.h:270:1), VALUE)' (aka 'unsigned long (*)(int, union
(unnamed at /Users/user/.rbenv/versions/3.1.4/include/ruby-3.1.0/ruby/internal/anyargs.h:270:1), unsigned long)') [-Wincompatible-function-pointer-types]

It is fixed by 1.5.6

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

@AliDatadog AliDatadog requested a review from a team as a code owner July 10, 2024 08:12
Copy link

@chouquette chouquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small nit on the commit message: this is rather updating the pinned version that pinning it

@AliDatadog AliDatadog merged commit 0f22248 into main Jul 10, 2024
12 of 13 checks passed
@AliDatadog AliDatadog deleted the ali/fix-jaro-winkler branch July 10, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants