-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing CI, local dev dockerfile setup, implement Centos 6 deprecation #913
Conversation
It failed in different ways; this mostly bumps the Ruby version and changes the keyserver URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just need to wait that the docker kitchen tests still works before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a minor suggestion, thanks!
Co-authored-by: jhgilbert <[email protected]>
To keep it more similar to our current CI tests
8dc678e
to
102c4f8
Compare
102c4f8
to
724940a
Compare
3ea035a
to
7d2bf61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from my single comment LGTM 🚀
What does this PR do?
Motivation
BARX-282
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist