Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test smarter, not harder #5166

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adamnovak
Copy link
Member

This should help with #5162. It doesn't move any tests around yet, but it reduces the number of test runs.

I also already turned off the constraint that branches be back-merged up to current mainline Toil before we merge them, to avoid double-testing the same code represented by different commits. Github doesn't have a squash-test-and-update-mainline-if-passing workflow, so the only way to test just the final commit that goes into the history seems to be to do it after merging.

Changelog Entry

To be copied to the draft changelog by merger:

  • Github PRs should no longer automatically be rebased and re-tested constantly
  • Dependabot should no longer try to update packages that CI doesn't exercise

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passes tests.
  • Make sure the PR has been reviewed since its last modification. If not, review it.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

adamnovak and others added 3 commits November 20, 2024 12:14
Make Dependabot not rebase or try to touch packages for stuff not under
CI. Stop Github from auto-rebasing all PRs for us.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant