feat: exports via main button don't include orphans (#287) #288
+152
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoopDog
requested review from
MillenniumFalconMechanic and
NoopDog
and removed request for
hunterckx
MillenniumFalconMechanic
requested changes
Dec 3, 2024
src/providers/fileManifestState.tsx
Outdated
| @@ -51,6 +51,7 @@ export type FileManifestState = { | |||
| isSummaryLoading: boolean; | |||
| requestParams?: URLSearchParams; | |||
| requestURL?: string; | |||
| setOfFormFacetNames: Set<FileFacet["name"]>; | |||
There was a problem hiding this comment.
What about renaming this to help indicate these are the selected set of form facet names (e.g. selectedFormFacetNames)?
|
|
||
| /** | ||
| * Generates the filters for a request URL based on the file manifest state. | ||
| * If all terms in a facet are selected, the corresponding facet is excluded. | ||
| * Determines if all form facet terms are fully selected. |
There was a problem hiding this comment.
Would you be able to add comments here about the "no values selected" case? (It took me a while to get that the no values case was considered fully selected.) Let me know if this isn't clear!
Comment on lines
38
to
46
| const SELECTED_FILTERS_FORM_COMPLETE_SET: Filters = [ | ||
| { categoryKey: "category01", value: ["value01", "value02"] }, | ||
| { categoryKey: "category02", value: ["value02", "value03", "value04"] }, | ||
| ]; | ||
|
|
||
| const FILTERS_SUBSET: Filters = [ | ||
| const SELECTED_FILTERS_FORM_SUBSET: Filters = [ | ||
| { categoryKey: "category01", value: ["value01"] }, | ||
| { categoryKey: "category02", value: ["value02", "value03", "value04"] }, | ||
| ]; |
There was a problem hiding this comment.
Could you add a third test case here where one of the categories has no selected values, so that the "no values equals all values" case is exercised?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #287.