Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: added file download tracking (#260) #263

Merged

Conversation

jpaten
Copy link
Contributor

@jpaten jpaten commented Nov 12, 2024

Changes

  • Added file_downloaded event and relevant models as specified in Add tracking of file download #260
  • Added call to this event in AzulFileDownload, adding new optional props as needed

@jpaten jpaten linked an issue Nov 12, 2024 that may be closed by this pull request
@jpaten jpaten marked this pull request as ready for review November 12, 2024 07:55
Copy link
Collaborator

@MillenniumFalconMechanic MillenniumFalconMechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Jonah! I've added a couple of comments. Can you also double-check the GTM parameter value limit? I was under the impression that parameter names are limited to 40 but parameter values can be 100.

src/components/Export/common/tracking.ts Outdated Show resolved Hide resolved
@jpaten
Copy link
Contributor Author

jpaten commented Nov 13, 2024

@MillenniumFalconMechanic my bad, I read the wrong limit, it is 100 characters. Some file names come very close to that, but I couldn't find any that have more than 100 characters, so this approach is probably fine

@jpaten
Copy link
Contributor Author

jpaten commented Nov 13, 2024

Breaking Changes @frano-m

  • AzulFileDownloaded has the following new required props
    • entityName
      • string
      • The filename for the file being downloaded
    • relatedEntityId
      • string
      • The ID(s) of the dataset(s) or project(s) associated with the file
      • If there are multiple different associated datasets or projects, they should be stringified in the viewModelBuilder before being passed here
    • relatedEntityName
      • string
      • The name(s) of the dataset(s) or project(s) associated with the file
      • If there are multiple different associated datasets or projects, they should be stringified in the viewModelBuilder before being passed here

Copy link
Contributor

@frano-m frano-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @jpaten 🚀

@NoopDog NoopDog force-pushed the jonah/260-add-tracking-of-file-download branch from d102cc5 to ac850fb Compare November 14, 2024 00:21
@NoopDog NoopDog changed the title feat: added file download tracking (#260) feat!: added file download tracking (#260) Nov 14, 2024
Copy link
Collaborator

@MillenniumFalconMechanic MillenniumFalconMechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Jonah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tracking of file download
3 participants