Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use ky with limited retries instead of axios (#203) #216

Merged
merged 8 commits into from
Oct 18, 2024

Conversation

hunterckx
Copy link
Contributor

@hunterckx hunterckx commented Oct 10, 2024

I've updated the api function to create a new Axios instance each time, rather than using a singleton, so that each instance can have its own retry process

  • ES modules in tests have to be imported after any relevant module mocks are done, so some of the imports in tests are changed to be async
  • Since entityURL doesn't appear to have been doing anything, I've removed it entirely

@hunterckx hunterckx marked this pull request as ready for review October 11, 2024 23:26
@hunterckx hunterckx changed the title feat: limit retries and use exponential backoff for api requests (#203) feat: use ky with limited retries instead of axios (#203) Oct 17, 2024
@hunterckx hunterckx changed the title feat: use ky with limited retries instead of axios (#203) feat!: use ky with limited retries instead of axios (#203) Oct 17, 2024
Copy link
Contributor

@frano-m frano-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @hunterckx 🎸 .

@NoopDog NoopDog merged commit ec18080 into main Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants