Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vp2420 minimal regression fixes #643

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Conversation

macpijan
Copy link
Contributor

@mkopec @filipleple can it break anything for laptops case?

@macpijan macpijan requested review from mkopec and miczyg1 December 19, 2024 09:31
@macpijan macpijan changed the base branch from main to develop December 19, 2024 09:31
@macpijan
Copy link
Contributor Author

Result from minimal regression so far: https://paste.dasharo.com/?6c2b1d03dfe0baec#2s9NXsoGVA8azbQ4BMg1bpyRDznhjXJ6HCZhJaqDzbV5

Comment:

  • USB keyboard - expected, not connected - I still think it's not the best case as it requires to manually connect physical keyboard to the platform each time we want to run the test
  • WiFi - need checking, do we even have a card there?
  • STB002.001 - caused by the incorrect printk settings in the OS, some details here: https://github.com/Dasharo/open-source-firmware-validation/pull/449/files; will rerun again

@macpijan
Copy link
Contributor Author

After setting:

cat /etc/sysctl.d/10-console-messages.conf 

# the following stops low-level messages on console
kernel.printk = 0 4 1 7

STB002.001 passed as well

@filipleple
Copy link
Member

This will make

        Login To Linux
        Switch To Root User

execute twice in a row on laptops, but I would guess doing this over SSH will be properly handled and won't cause any problems

@macpijan
Copy link
Contributor Author

Can you elaborate @filipleple ? Can you please explain where does the second one come from?

@filipleple
Copy link
Member

@macpijan sorry, I must've been looking at some older revision, I checked the Boot System... keyword again and it should align nicely with the changes to lib/flash, causing no trouble with laptops.

macpijan and others added 3 commits December 31, 2024 10:17
Clearly this has not been tested before, as the Make Sure ...
kwd needs to be in the Linux shell.

Signed-off-by: Maciej Pijanowski <[email protected]>
@macpijan macpijan force-pushed the vp2420-minimal-regression-fixes branch from 96b0c24 to cd4afc8 Compare December 31, 2024 09:17
@macpijan macpijan merged commit cd4afc8 into develop Dec 31, 2024
1 check was pending
@macpijan macpijan deleted the vp2420-minimal-regression-fixes branch December 31, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants