Add submodule

[wiktormowinski]

No description provided.

[wiktormowinski]

looks like i can't update all secure boot links because of this kwd Download ISO And Mount As USB more specifically the pikvm part:

 IF    "${DUT_CONNECTION_METHOD}" == "pikvm"
            Upload Image To PiKVM    ${PIKVM_IP}    ${img_url}    ${img_name}
            Mount Image On PiKVM    ${PIKVM_IP}    ${img_name}
        ELSE
            Skip    unsupported
        END

[JanPrusinowski]

looks like i can't update all secure boot links because of this kwd Download ISO And Mount As USB more specifically the pikvm part:

 IF    "${DUT_CONNECTION_METHOD}" == "pikvm"
            Upload Image To PiKVM    ${PIKVM_IP}    ${img_url}    ${img_name}
            Mount Image On PiKVM    ${PIKVM_IP}    ${img_name}
        ELSE
            Skip    unsupported
        END

What is the actual issue? That the remote source can't be mounted? Can;t it be downloaded locally and then mounted?

[JanPrusinowski]

In Download ISO And Mount As USB a different command was used: Upload Image To PiKVM what is the reason for change?

I cant find this keyword. Did you ad it on your own? Could you add it to the PR?

[wiktormowinski]

that kwd is a part of pikvm-rest-api submodule and thats where i put it: 3mdeb/pikvm-rest-api@main...secure-boot-local-img-upload-add and the reason why i made a different kwd is that on pikvm wiki i read, you need different arguments if you want to upload file from local (Upload Image To PiKVM uses url to send that file) and different from link

[JanPrusinowski]

Could you point to that KWD?

[macpijan]

I left some suggestions regarding this kwd in pikvm module here: https://github.com/3mdeb/pikvm-rest-api/pull/16/files#r1812874751

[macpijan]

What is the point of this operation to copy from one local directory to another? Now that we have submodule with test data already in place, this seems redundant, doesn't it? It made some sense before when we used to download these files from various sources.