Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC Engines Legacy support #213

Open
wants to merge 14 commits into
base: configs-rework
Choose a base branch
from
Open

Conversation

pietrushnic
Copy link
Contributor

No description provided.

mkopec and others added 14 commits March 4, 2024 11:54
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
@pietrushnic pietrushnic requested review from mkopec and macpijan March 4, 2024 15:39
@pietrushnic pietrushnic changed the base branch from main to pcengines March 4, 2024 15:39
@pietrushnic pietrushnic changed the title Pcnegines legacy PC Engines Legacy support Mar 4, 2024
Base automatically changed from pcengines to configs-rework March 10, 2024 18:36
${USB_TYPE-A_DEVICES_DETECTION_SUPPORT}= ${TRUE}

*** Keywords ***
Power On
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this can be shared no matter what FW type we use

${TESTS_IN_FIRMWARE_SUPPORT}= ${TRUE}
${TESTS_IN_UBUNTU_SUPPORT}= ${TRUE}

# Regression test flags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these flags will enable running tests, which assume edk2 payload is there. We either need extra flag, or different flags for new SeaBIOS tests. I am not sure right now, we need to trye out.

@macpijan
Copy link
Contributor

macpijan commented Dec 2, 2024

This will be still valid, or rather replaced with the: #574 @pietrushnic ?

@pietrushnic
Copy link
Contributor Author

@macpijan maybe something of this PR can be used/adopted, but most of the work related to support of PC Engines is made from scratch in #574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants