Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distro: dts-scripts: fix check_for_dasharo_firmware #212

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

DaniilKl
Copy link
Contributor

@DaniilKl DaniilKl commented Dec 23, 2024

Related PR: Dasharo/dts-scripts#58.

@DaniilKl DaniilKl self-assigned this Dec 23, 2024
@DaniilKl
Copy link
Contributor Author

DaniilKl commented Dec 23, 2024

The build test will fail because Dasharo/dts-scripts#58 is not merged, so the tests should be rerun after merging the related PR.

Manual tests:

Some of the credentials are empty:

*********************************************************
R to reboot  P to poweroff  S to enter shell  
K to launch SSH server  L to enable sending DTS logs 
V to enable verbose mode 
Enter an option:
4

Enter logs key:                
Logs key is empty, discarding credentials...
Press Enter to continue.
*********************************************************
R to reboot  P to poweroff  S to enter shell  
K to launch SSH server  L to enable sending DTS logs 
V to enable verbose mode 
Enter an option:
4

Enter logs key:                xxx

Enter firmware download key:   
Download key is empty, discarding credentials...
Press Enter to continue.
*********************************************************
R to reboot  P to poweroff  S to enter shell  
K to launch SSH server  L to enable sending DTS logs 
V to enable verbose mode 
Enter an option:
4

Enter logs key:                xxx

Enter firmware download key:   xxx

Enter password:                
Password is empty, discarding credentials...
Press Enter to continue.

Fake credentials:

*********************************************************
R to reboot  P to poweroff  S to enter shell  
K to launch SSH server  L to enable sending DTS logs 
V to enable verbose mode 
Enter an option:
4

Enter logs key:                xxx

Enter firmware download key:   xxx

Enter password:                xxx
Dasharo DPP credentials have been saved
Checking for Dasharo firmware...
Waiting for network connection ...
Network connection have been established!
Checking if board is Dasharo compatible.
There is no Dasharo Firmware available for your platform.
Your credentials give access to:
Dasharo Pro Package (DPP): NO
DTS Extensions: NO
Press Enter to continue

True credentials:

*********************************************************
R to reboot  P to poweroff  S to enter shell  
K to launch SSH server  L to enable sending DTS logs 
V to enable verbose mode 
Enter an option:
4

Enter logs key:                xxx

Enter firmware download key:   xxx

Enter password:                xxx
Dasharo DPP credentials have been saved
Checking for Dasharo firmware...
Waiting for network connection ...
Network connection have been established!
Checking if board is Dasharo compatible.
There is no Dasharo Firmware available for your platform.
Your credentials give access to:
Dasharo Pro Package (DPP): NO
DTS Extensions: YES
Checking for available DPP packages...
Installing available DPP packages...
Installing package some-package-git-r0.core2_64.rpm...
Downloading package some-package-git-r0.core2_64.rpm...
`premium/des-packages/some-package-git-r0.core2_64.rpm` -> `/var/dasharo-package-manager/some-package-git-r0.core2_64.rpm`
mc: <ERROR> Access Denied.
Press Enter to continue.

Do no mind mc: <ERROR> Access Denied. because these credentials were set only to view packages, not to download. But Dasharo Package Manager requires both.

@m-iwanicki
Copy link
Contributor

Works, but there is problem that if you enter wrong credentials after you used correct ones then DTS extensions still uses correct ones while DPP tries to use new ones.

@DaniilKl
Copy link
Contributor Author

DaniilKl commented Dec 23, 2024

Works, but there is problem that if you enter wrong credentials after you used correct ones then DTS extensions still uses correct ones while DPP tries to use new ones.

This is not in the scope of this PR, you should consider adding issue. Good note btw.

@DaniilKl
Copy link
Contributor Author

DaniilKl commented Jan 2, 2025

@m-iwanicki, if you think that these changes are OK - approve the related PR Dasharo/dts-scripts#58 so I can run tests on QEMU here.

@m-iwanicki
Copy link
Contributor

You should probably merge to develop and then develop to main (this would be the only new commit so nothing new would be added).

@DaniilKl DaniilKl changed the base branch from main to develop January 2, 2025 09:41
@DaniilKl DaniilKl merged commit bbfec27 into develop Jan 2, 2025
5 checks passed
@DaniilKl DaniilKl deleted the fix-check-for-dasharo-firmware branch January 2, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants