.github/workflows/main.yml: run CI on dasharo branches #4
Conversation
mkopec
force-pushed
the
dasharo-ci
branch
20 times, most recently
from
afa1d75 to
06e5b69
Compare
|
@mkopec is it still a draft? |
|
@macpijan Yes, at the moment it builds for debian only. Won't work for ubuntu |
mkopec
force-pushed
the
dasharo-ci
branch
5 times, most recently
from
9136883 to
7b30f38
Compare
mkopec
force-pushed
the
dasharo-ci
branch
5 times, most recently
from
6554fa6 to
b2e04ea
Compare
For building packages only. Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
|
@macpijan Rebased, ready for review. Packages are built for Ubuntu 20.04 and can be installed correctly. Only the |
| @@ -1596,6 +1660,7 @@ | |||
| </distro> | |||
| <distro id="ubuntu"> | |||
| <package variant="x86_64" /> | |||
| <package variant="20.04" /> | |||
There was a problem hiding this comment.
@mkopec Why do we need this change and it was not presetn in the usptream? Is it upstreamable?
There was a problem hiding this comment.
fwupd upstream doesn't build packages for ubuntu. I tried adding a new variant ubuntu-20.04 with a different CI script for ubuntu, but at the moment this code is unused.
There was a problem hiding this comment.
@mkopec Well, I think it is used.
Here: https://github.com/Dasharo/fwupd/blob/dasharo-ci/contrib/ci/debian.sh#L34
Then here: https://github.com/Dasharo/fwupd/blob/dasharo-ci/contrib/ci/generate_debian.py#L36
There was a problem hiding this comment.
It is used to fill in the dependencies here: https://github.com/Dasharo/fwupd/blob/dasharo-ci/contrib/debian/control.in#L7
There was a problem hiding this comment.
Ok, maybe this 20.04 does not make much sense. But we need to provide OS=ubuntu-x86_64 as a variable, so the contrib is generated correctly.
No description provided.