-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/variants/protectli_vp2430: add #932
base: master
Are you sure you want to change the base?
Conversation
0cebf4b
to
dee06db
Compare
65f6dd5
to
1b5dc08
Compare
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
1b5dc08
to
60a918c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Will probably have to wait before merging, as the board will probably have to remain hidden.
Is it possible that we "hide" the boards by simply commenting out them in menu layout: https://github.com/Dasharo/docs/pull/932/files#diff-98d0f806abc9af24e6a7c545d3d77e8f9ad57643e27211d7a7b896113e420ed2R334 providing some reasoning? Leaving unmerged PRs means they got stale and need to be rebased over and over. WDYT @BeataZdunczyk @miczyg1 @filipleple Can we use such a process here? |
You can comment the files in the TOC. But there are also tabs in the unified documentation which you would have to comment with HTML marks AFAIK |
Signed-off-by: Filip Lewiński <[email protected]>
@macpijan I've commented out all of the additions as suggested. I don't understand why pre-commit complains only about the lines I've added in |
No description provided.