Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/variants/protectli_vp2430: add #932

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

docs/variants/protectli_vp2430: add #932

wants to merge 3 commits into from

Conversation

filipleple
Copy link
Member

No description provided.

@filipleple filipleple self-assigned this Nov 7, 2024
@filipleple filipleple force-pushed the vp2430_add branch 2 times, most recently from 0cebf4b to dee06db Compare November 13, 2024 11:46
@filipleple filipleple marked this pull request as ready for review November 13, 2024 14:23
docs/unified/protectli/overview.md Outdated Show resolved Hide resolved
docs/unified/protectli/recovery.md Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
docs/variants/protectli_vp2430/releases.md Outdated Show resolved Hide resolved
Copy link
Contributor

@miczyg1 miczyg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will probably have to wait before merging, as the board will probably have to remain hidden.

@macpijan
Copy link
Contributor

Is it possible that we "hide" the boards by simply commenting out them in menu layout: https://github.com/Dasharo/docs/pull/932/files#diff-98d0f806abc9af24e6a7c545d3d77e8f9ad57643e27211d7a7b896113e420ed2R334 providing some reasoning?

Leaving unmerged PRs means they got stale and need to be rebased over and over.

WDYT @BeataZdunczyk @miczyg1 @filipleple Can we use such a process here?

@miczyg1
Copy link
Contributor

miczyg1 commented Dec 10, 2024

Is it possible that we "hide" the boards by simply commenting out them in menu layout: https://github.com/Dasharo/docs/pull/932/files#diff-98d0f806abc9af24e6a7c545d3d77e8f9ad57643e27211d7a7b896113e420ed2R334 providing some reasoning?

Leaving unmerged PRs means they got stale and need to be rebased over and over.

WDYT @BeataZdunczyk @miczyg1 @filipleple Can we use such a process here?

You can comment the files in the TOC. But there are also tabs in the unified documentation which you would have to comment with HTML marks AFAIK

@filipleple
Copy link
Member Author

filipleple commented Dec 19, 2024

@macpijan I've commented out all of the additions as suggested. I don't understand why pre-commit complains only about the lines I've added in protectli/test-matrix.md, while almost all of the lines in that file have always exceeded the 80 character limit. Also this approach means we'll pretty much always have some orphan pages detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants