Protectli vault adl n typec #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miczyg1 I'm not sure I see the relation between these changes and TPM PPI, is that a mistake? |
Wrong PR... |
|
Sorry, it is not meant for review yet. Uploaded this PR only for testing purposes... |
miczyg1
force-pushed
the
protectli_vault_adl_n_typec
branch
2 times, most recently
from
3bb58ef to
eddad3c
Compare
|
Now it is ready for review. I looks like I forgot about PMC mux conn entries in devicetree, but they caused the Type-C display to not work anymore. As a w/a I have instructed the FSP to program AUX bias pads. Details in commit messages. |
…tions Signed-off-by: Michał Żygowski <[email protected]>
Adding PMC mux_conn entries to devicetree causes coreboot to program AUX bias pads before the multiphase silicon init according to typec_aux_bias_pads values. However, it seems too late in the intialization flow and Type-C displays stop working. In order to have the PMC mux_conn generate the ACPI code and still keep the Type-C display working in FW, let FSP program the AUX bias pads. TEST=Check Type-C display works on VP3210 in both OS and FW. Signed-off-by: Michał Żygowski <[email protected]>
miczyg1
force-pushed
the
protectli_vault_adl_n_typec
branch
from
474e56c to
4554ffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.