-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Msi ms7d25/fan control #404
Conversation
Sample output from sensors:
Before the PR, some temperatures and voltages were not reported. CPU Fan also spinned at fixed speed above 1000RPM. When idling, the fan speed is so low, it is not even reported:
|
Based on NCT6686D HW datasheet and NCT6686D EC space datasheet (the former is public, the latter I got from a request issued to Nuvoton company). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, I can make use of this for #402 too ;)
I could not see obvious issues here, but I may have missed something.
Hmm, M900 also has NCT6686D/NCT6687D? Cool. Note I have only tested Smart Fan IV initialization. All fan modes are implemented as per the EC space datasheet, so should be correct. However, I have not tried all possible configurations, there is plenty of them as you can see (various tracking methods, startup_duty, manual_offset, min_duty, ambient floor, Intel DTS based control, etc.). I am only afraid of messing up the definitions in |
Signed-off-by: Michał Żygowski <[email protected]> Change-Id: Ib78ad052204009dc1f9b90ad2272a83b304fd39d
…ect vendor BIOS init Signed-off-by: Michał Żygowski <[email protected]> Change-Id: I7cc82fc355de7982b937e9dc58b921bdf05d5b74
Signed-off-by: Michał Żygowski <[email protected]> Change-Id: I7a207a8555466f3c4ce888ad7ed90367ff2ae12e
Signed-off-by: Michał Żygowski <[email protected]> Change-Id: Ieb282c33ed9f970e02bd915ddc92e8d66b553ba6
a38410e
to
ec1b447
Compare
No description provided.