Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msi ms7d25/fan control #404

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Msi ms7d25/fan control #404

merged 4 commits into from
Sep 27, 2023

Conversation

miczyg1
Copy link
Contributor

@miczyg1 miczyg1 commented Sep 24, 2023

No description provided.

@miczyg1
Copy link
Contributor Author

miczyg1 commented Sep 24, 2023

Sample output from sensors:

nct6687-isa-0a20
Adapter: ISA adapter
+12V:           12.22 V  (min = +12.19 V, max = +12.22 V)
+5V:             5.06 V  (min =  +5.06 V, max =  +5.07 V)
+3.3V:           0.00 V  (min =  +0.00 V, max =  +0.00 V)
CPU Soc:         1.23 V  (min =  +0.66 V, max =  +1.23 V)
CPU Vcore:     600.00 mV (min =  +0.60 V, max =  +0.60 V)
CPU 1P8:         0.00 V  (min =  +0.00 V, max =  +0.00 V)
CPU VDDP:        0.00 V  (min =  +0.00 V, max =  +0.00 V)
DRAM:            2.50 V  (min =  +1.32 V, max =  +2.50 V)
Chipset:       898.00 mV (min =  +0.90 V, max =  +0.90 V)
CPU SA:        902.00 mV (min =  +0.90 V, max =  +0.90 V)
Voltage #2:      1.54 V  (min =  +1.53 V, max =  +1.54 V)
AVCC3:           3.34 V  (min =  +3.34 V, max =  +3.35 V)
AVSB:            0.00 V  (min =  +0.00 V, max =  +0.00 V)
VBat:            0.00 V  (min =  +0.00 V, max =  +0.00 V)
CPU Fan:       1050 RPM  (min =    0 RPM, max = 1068 RPM)
Pump Fan:         0 RPM  (min =    0 RPM, max =    0 RPM)
System Fan #1:  998 RPM  (min =  982 RPM, max = 1008 RPM)
System Fan #2:  995 RPM  (min =  990 RPM, max = 1007 RPM)
System Fan #3: 1027 RPM  (min =  998 RPM, max = 1028 RPM)
System Fan #4:    0 RPM  (min =    0 RPM, max =    0 RPM)
System Fan #5:    0 RPM  (min =    0 RPM, max =    0 RPM)
System Fan #6:  863 RPM  (min =  822 RPM, max =  863 RPM)
CPU:            +64.5°C  (low  = +31.5°C, high = +65.5°C)
System:         +37.0°C  (low  = +34.0°C, high = +37.0°C)
VRM MOS:        +31.0°C  (low  = +28.0°C, high = +31.0°C)
PCH:            +60.0°C  (low  = +52.0°C, high = +60.0°C)
CPU Socket:     +36.0°C  (low  = +29.0°C, high = +36.0°C)
PCIe x1:        +32.0°C  (low  = +31.0°C, high = +32.0°C)
M2_1:           +31.5°C  (low  = +31.5°C, high = +32.0°C)

Before the PR, some temperatures and voltages were not reported. CPU Fan also spinned at fixed speed above 1000RPM. When idling, the fan speed is so low, it is not even reported:

nct6687-isa-0a20
Adapter: ISA adapter
+12V:           12.19 V  (min = +12.19 V, max = +12.22 V)
+5V:             5.06 V  (min =  +5.06 V, max =  +5.07 V)
+3.3V:           0.00 V  (min =  +0.00 V, max =  +0.00 V)
CPU Soc:       916.00 mV (min =  +0.66 V, max =  +1.23 V)
CPU Vcore:     600.00 mV (min =  +0.60 V, max =  +0.60 V)
CPU 1P8:         0.00 V  (min =  +0.00 V, max =  +0.00 V)
CPU VDDP:        0.00 V  (min =  +0.00 V, max =  +0.00 V)
DRAM:            1.89 V  (min =  +1.32 V, max =  +2.50 V)
Chipset:       898.00 mV (min =  +0.90 V, max =  +0.90 V)
CPU SA:        898.00 mV (min =  +0.90 V, max =  +0.90 V)
Voltage #2:      1.54 V  (min =  +1.53 V, max =  +1.54 V)
AVCC3:           3.34 V  (min =  +3.34 V, max =  +3.35 V)
AVSB:            0.00 V  (min =  +0.00 V, max =  +0.00 V)
VBat:            0.00 V  (min =  +0.00 V, max =  +0.00 V)
CPU Fan:          0 RPM  (min =    0 RPM, max = 1068 RPM)
Pump Fan:         0 RPM  (min =    0 RPM, max =    0 RPM)
System Fan #1:  994 RPM  (min =  982 RPM, max = 1008 RPM)
System Fan #2: 1004 RPM  (min =  990 RPM, max = 1007 RPM)
System Fan #3: 1003 RPM  (min =  998 RPM, max = 1028 RPM)
System Fan #4:    0 RPM  (min =    0 RPM, max =    0 RPM)
System Fan #5:    0 RPM  (min =    0 RPM, max =    0 RPM)
System Fan #6:  843 RPM  (min =  822 RPM, max =  863 RPM)
CPU:            +39.5°C  (low  = +31.5°C, high = +65.5°C)
System:         +38.5°C  (low  = +34.0°C, high = +38.5°C)
VRM MOS:        +32.0°C  (low  = +28.0°C, high = +32.0°C)
PCH:            +61.0°C  (low  = +52.0°C, high = +61.0°C)
CPU Socket:     +35.5°C  (low  = +29.0°C, high = +36.0°C)
PCIe x1:        +32.0°C  (low  = +31.0°C, high = +32.0°C)
M2_1:           +32.0°C  (low  = +31.5°C, high = +32.0°C)

@miczyg1
Copy link
Contributor Author

miczyg1 commented Sep 27, 2023

Based on NCT6686D HW datasheet and NCT6686D EC space datasheet (the former is public, the latter I got from a request issued to Nuvoton company).

Copy link
Member

@mkopec mkopec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I can make use of this for #402 too ;)

I could not see obvious issues here, but I may have missed something.

@miczyg1
Copy link
Contributor Author

miczyg1 commented Sep 27, 2023

Hmm, M900 also has NCT6686D/NCT6687D? Cool.

Note I have only tested Smart Fan IV initialization. All fan modes are implemented as per the EC space datasheet, so should be correct. However, I have not tried all possible configurations, there is plenty of them as you can see (various tracking methods, startup_duty, manual_offset, min_duty, ambient floor, Intel DTS based control, etc.).

I am only afraid of messing up the definitions in src/superio/nuvoton/nct6687d/nct6687d_hwm.h or not using all of the registers somewhere...

Signed-off-by: Michał Żygowski <[email protected]>
Change-Id: Ib78ad052204009dc1f9b90ad2272a83b304fd39d
…ect vendor BIOS init

Signed-off-by: Michał Żygowski <[email protected]>
Change-Id: I7cc82fc355de7982b937e9dc58b921bdf05d5b74
Signed-off-by: Michał Żygowski <[email protected]>
Change-Id: I7a207a8555466f3c4ce888ad7ed90367ff2ae12e
Signed-off-by: Michał Żygowski <[email protected]>
Change-Id: Ieb282c33ed9f970e02bd915ddc92e8d66b553ba6
@miczyg1 miczyg1 force-pushed the msi_ms7d25/fan_control branch from a38410e to ec1b447 Compare September 27, 2023 14:42
@miczyg1 miczyg1 merged commit ec1b447 into msi_ms7d25/develop Sep 27, 2023
@miczyg1 miczyg1 deleted the msi_ms7d25/fan_control branch September 27, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants