chore: remove unneeded Component.cpp, forward declare dependencies, and make Component definition header-only #1688
+15
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Component definition header-only
jadebenn
requested review from
aronwk-aaron,
EmosewaMC,
Jettford and
Xiphoseer
jadebenn
changed the title
aronwk-aaron
approved these changes
Dec 18, 2024
|
imagine using labels couldnt be me |
EmosewaMC
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Component.cpp file consists of only empty functions and isn't needed. Tinyxml2.h and raknet can also be forward-declared