Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove reinterpret_casts from AG race timer script and add method and chat command to get current server uptime #1673

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jadebenn
Copy link
Collaborator

@jadebenn jadebenn commented Dec 8, 2024

Tested in game by running the race and verified that mission 1884 is correctly marked as completed when race is finished

EmosewaMC
EmosewaMC previously approved these changes Dec 8, 2024
Copy link
Collaborator

@EmosewaMC EmosewaMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the achievements only work if you get below the target time as well?

@jadebenn
Copy link
Collaborator Author

Marking this as draft as I want to modify the implementation and run a few more tests

@jadebenn jadebenn marked this pull request as draft December 10, 2024 23:03
@jadebenn jadebenn changed the title chore: Remove reinterpret_casts from AG race timer script feat: Remove reinterpret_casts from AG race timer script and add method and chat command to get current server uptime Dec 14, 2024
@jadebenn jadebenn requested a review from EmosewaMC December 14, 2024 22:09
@jadebenn
Copy link
Collaborator Author

Tested that achievements work correctly

@jadebenn jadebenn marked this pull request as ready for review December 14, 2024 22:09
EmosewaMC
EmosewaMC previously approved these changes Dec 14, 2024
dScripts/02_server/Map/AG/NpcAgCourseStarter.cpp Outdated Show resolved Hide resolved
dScripts/02_server/Map/AG/NpcAgCourseStarter.cpp Outdated Show resolved Hide resolved
dScripts/02_server/Map/AG/NpcAgCourseStarter.cpp Outdated Show resolved Hide resolved
docs/Commands.md Outdated Show resolved Hide resolved
@EmosewaMC
Copy link
Collaborator

i forgot if i approved this or not

Copy link
Collaborator

@EmosewaMC EmosewaMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just in case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants