fix: Dockerfile vanity COPY #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected an unintended mistake in the COPY commands for adding the vanity files to the Docker container, causing only the last file contents to be added to the file '/app/vanity/*'
aronwk-aaron
approved these changes
May 27, 2024
EmosewaMC
approved these changes
May 27, 2024
|
Thanks for spotting this and submitting a fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current COPY directives in the Dockerfile that add the vanity files have an unintended trailing asterisk, causing only root.xml's contents to be in there under the filename '*'.
This is obviously unintendend as this causes the vanity to be non-functional in the default docker setup.