feat: Help Command Pagination #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performed tests after merging with main and the previous sorting changes. Running |
EmosewaMC
requested changes
May 17, 2024
Now able to do /command help to see info for said command. Additionally this works for aliases. Fixed serialization missing from merge.
|
Reverted code and reimplemented /help , rather than / help. Alongside keeping pagination |
aronwk-aaron
previously approved these changes
May 21, 2024
EmosewaMC
requested changes
May 21, 2024
EmosewaMC
reviewed
May 21, 2024
EmosewaMC
approved these changes
May 22, 2024
aronwk-aaron
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Help Command Pagination
Description: Changed HelpCommand to now be sorted into different pages for commands, which should help to further help users to find the correct commands they are looking for without having to scroll through a list of 92 commands.
Motivation and Context: Recommendation from Aron, and my own experience reading through the /help command list.
How Has This Been Tested?: Running my server and using the /help command will return page 1 of the command list. Running /help 1 will as well, but /help 2 and so forth will return that respective page number of commands (currently 10 commands per page). If a user tries to enter a command higher than the number of pages, it will say it is an invalid page number. Additionally, commands will only show up given the user has the proper GMLevel to use that command.