Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Command Sorting #1580

Merged
merged 23 commits into from
May 17, 2024
Merged

feat: Command Sorting #1580

merged 23 commits into from
May 17, 2024

Conversation

Tiernan-Alderman
Copy link
Contributor

feat: Command Organization

Description: Changed CommandInfos to be a map rather than a vector, which allows for easy alphabetization of the different commands available when running /help.

Motivation and Context: Found it hard to sort through the list of commands as it was, so this should be helpful for users to find the commands they are looking for.

How Has This Been Tested?: Running my server and using the help command, for it to show the resulting command list in alphabetical order

@aronwk-aaron aronwk-aaron changed the title /Help Alphabetization feat: Command Organization May 14, 2024
@aronwk-aaron aronwk-aaron changed the title feat: Command Organization feat: Command Sorting May 14, 2024
@EmosewaMC
Copy link
Collaborator

The files are still not formatted to our standard. Please format them

@EmosewaMC
Copy link
Collaborator

All feedback from the other pr aside from the lambda to function still must be addressed

@Tiernan-Alderman
Copy link
Contributor Author

The files are still not formatted to our standard. Please format them

Is it formatted to the standard now?

@EmosewaMC
Copy link
Collaborator

The files are still not formatted to our standard. Please format them

Is it formatted to the standard now?

it is not. there have been no pushes to this branch yet since my comment on the last pr

@Tiernan-Alderman
Copy link
Contributor Author

The files are still not formatted to our standard. Please format them

Is it formatted to the standard now?

it is not. there have been no pushes to this branch yet since my comment on the last pr

how abour now

@EmosewaMC
Copy link
Collaborator

The files are still not formatted to our standard. Please format them

Is it formatted to the standard now?

it is not. there have been no pushes to this branch yet since my comment on the last pr

how abour now

It is not formatted correctly after that push, if anything that push just made more lines 4 spaces instead of a tab

@Tiernan-Alderman
Copy link
Contributor Author

It is not formatted correctly after that push, if anything that push just made more lines 4 spaces instead of a tab

Ok I set up the tab stops setting and tried it, did it work?

@EmosewaMC
Copy link
Collaborator

It is not formatted correctly after that push, if anything that push just made more lines 4 spaces instead of a tab

Ok I set up the tab stops setting and tried it, did it work?

you didnt push your changes

EmosewaMC
EmosewaMC approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@EmosewaMC EmosewaMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI. Please also post the tests you did on the last commit with changes to this branch

@Tiernan-Alderman
Copy link
Contributor Author

Pending CI. Please also post the tests you did on the last commit with changes to this branch

https://youtu.be/vzjk0NxxUus

@EmosewaMC EmosewaMC requested review from jadebenn and Jettford May 17, 2024 00:45
@EmosewaMC EmosewaMC merged commit c8e0bb0 into DarkflameUniverse:main May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmosewaMC EmosewaMC EmosewaMC approved these changes

@aronwk-aaron aronwk-aaron aronwk-aaron approved these changes

@jadebenn jadebenn Awaiting requested review from jadebenn

@Jettford Jettford Awaiting requested review from Jettford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tiernan-Alderman @EmosewaMC @aronwk-aaron