feat: Help command alphabetization #1575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed /help command to now be sorted alphabetically, as well as have different pages
EmosewaMC
requested changes
May 14, 2024
EmosewaMC
requested changes
May 14, 2024
|
|
||
| // Inserting into CommandInfos using the first alias as the key | ||
| if (!command.aliases.empty()) { | ||
| CommandInfos.insert(std::make_pair(command.aliases[0], command)); |
There was a problem hiding this comment.
Suggested change
| CommandInfos.insert(std::make_pair(command.aliases[0], command)); | |
| CommandInfos[command.aliases[0]] = command; |
Comment on lines
+871
to
+886
| .handle = [](Entity* entity, const SystemAddress& sysAddr, const std::string& args) { | ||
| std::ostringstream feedback; | ||
| feedback << "----- Commands -----"; | ||
|
|
||
| // Loop through CommandInfos and display commands the player can access | ||
| for (const auto& [alias, command] : CommandInfos) { | ||
| if (command.requiredLevel <= entity->GetGMLevel()) { | ||
| LOG("Help command: %s", alias.c_str()); | ||
| feedback << "\n/" << alias << ": " << command.help; | ||
| } | ||
| } | ||
|
|
||
| // Send feedback text | ||
| const auto feedbackStr = feedback.str(); | ||
| if (!feedbackStr.empty()) GameMessages::SendSlashCommandFeedbackText(entity, GeneralUtils::ASCIIToUTF16(feedbackStr)); | ||
| }, |
There was a problem hiding this comment.
Please move this back to being its own function
| // Loop through CommandInfos and display commands the player can access | ||
| for (const auto& [alias, command] : CommandInfos) { | ||
| if (command.requiredLevel <= entity->GetGMLevel()) { | ||
| LOG("Help command: %s", alias.c_str()); |
There was a problem hiding this comment.
Suggested change
| LOG("Help command: %s", alias.c_str()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Command Organization
Description: Changed CommandInfos to be a map rather than a vector, which allows for easy alphabetization of the different commands available when running /help.
Motivation and Context: Found it hard to sort through the list of commands as it was, so this should be helpful for users to find the commands they are looking for.
How Has This Been Tested?: Running my server and using the help command, for it to show the resulting command list in alphabetical order