Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dragonmaw #1562

Merged
merged 12 commits into from
May 10, 2024
Merged

feat: Dragonmaw #1562

merged 12 commits into from
May 10, 2024

Conversation

EmosewaMC
Copy link
Collaborator

@EmosewaMC EmosewaMC commented May 8, 2024

Fixes all outstanding Dragonmaw specific issues that made the race track an abomination to race on. Other issues that apply to all racetracks still exist (spend too long falling when driving off edge, checkpoint triggers being odd, exploits of lap counting etc.)

  • no more invisible walls in the hatchery
  • lap 2 and 3 ramps/pillars are moved into place at the correct time
  • lap 2 and 3 ramps/pillars now play their animations
  • RigidBodyPhantoms now correctly act like phantoms
  • Added RigidBodyPhantom position/rotation getters and setters to entity
  • Add all scripts for Dragonmaw
  • Fix triggers for Refinery fumes such that they now smash the player if driven into
  • Utilize isRespawnPoint on racing checkpoints to prevent spawning on checkpoints that were marked as non-usable
  • Consolidate PhantomPhysics loading logic to the shared PhysicsComponent
  • Add debug information for sphere dpShapes

All code has been tested by myself in a few races to check that ramps and pillars are in the correct spots and do not move over time as well as the phantoms smashing the player and placing them at the very least at a safe checkpoint (driving on the left side does not trigger the checkpoint because how we do the range check does not take that side into account, but you do respawn somewhere safe). I will be enlisting further testers to ensure functionality.

Fixes #172

Thank you aron for implementing a lot of the scripts

@EmosewaMC EmosewaMC changed the title feat: Fix Dragonmaw feat: Dragonmaw May 8, 2024
@EmosewaMC
Copy link
Collaborator Author

This will be marked ready for review when I believe enough testing has been done

@aronwk-aaron
Copy link
Member

rigid as heck

@EmosewaMC EmosewaMC marked this pull request as ready for review May 9, 2024 11:28
aronwk-aaron
aronwk-aaron previously approved these changes May 9, 2024
Jettford
Jettford previously approved these changes May 9, 2024
@EmosewaMC EmosewaMC dismissed stale reviews from Jettford and aronwk-aaron via feb6a64 May 10, 2024 03:17
@aronwk-aaron aronwk-aaron requested a review from Jettford May 10, 2024 12:53
Copy link
Collaborator

@Jettford Jettford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aronwk-aaron aronwk-aaron merged commit 2ca61c3 into main May 10, 2024
4 checks passed
@aronwk-aaron aronwk-aaron deleted the phys branch May 10, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Dragonmaw chasm fumes do no damage
3 participants