-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Dragonmaw #1562
Merged
Merged
feat: Dragonmaw #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be marked ready for review when I believe enough testing has been done |
|
aronwk-aaron
previously approved these changes
May 9, 2024
Jettford
previously approved these changes
May 9, 2024
aronwk-aaron
approved these changes
May 10, 2024
Jettford
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all outstanding Dragonmaw specific issues that made the race track an abomination to race on. Other issues that apply to all racetracks still exist (spend too long falling when driving off edge, checkpoint triggers being odd, exploits of lap counting etc.)
All code has been tested by myself in a few races to check that ramps and pillars are in the correct spots and do not move over time as well as the phantoms smashing the player and placing them at the very least at a safe checkpoint (driving on the left side does not trigger the checkpoint because how we do the range check does not take that side into account, but you do respawn somewhere safe). I will be enlisting further testers to ensure functionality.
Fixes #172
Thank you aron for implementing a lot of the scripts