feat: chat web api mvp #1550
Draft
feat: chat web api mvp #1550
+293
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronwk-aaron
force-pushed
the
chat-http-api
branch
from
a3faa21 to
55a52b6
Compare
who->players add teams endpoint
|
|
|
|
|
|
use config vars to disable the api and whitelist listen IP
aronwk-aaron
requested review from
jadebenn,
Xiphoseer,
Wincent01 and
EmosewaMC
EmosewaMC
reviewed
Apr 25, 2024
Co-authored-by: David Markowitz <[email protected]>
Co-authored-by: David Markowitz <[email protected]>
EmosewaMC
previously approved these changes
Apr 26, 2024
EmosewaMC
dismissed
their stale review
This is not threadsafe as I just realized.
|
NOTHING IS THREADSAFE sdlfnsdljfhasd;jklfsdljfnsdjklfnosdjklnf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web API for Chat server Minimum Viable Product
Features:
resolves #450