Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: slashcommands for showall, findplayer, get/openhttpmoninfo, and debug world packet #1545

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

aronwk-aaron
Copy link
Member

/showall and /findplayer use custom packets and are live accurate /who variations

/gethttpmoninfo and /openhttpmoninfo are planned to be used later, just putting in info since it's been RE-d and don't want it lost

Additionally add debug worldPacket for future dev use

Tested all new commands and variation of command arguments

http monitor info is planned to be used later, just putting in info that i've since reverse engineered and don't want lost

Additionally add debug world packet for duture dev use

Tested all new commands and variation of command arguments
@aronwk-aaron
Copy link
Member Author

image
There is a quirk with httpmoninfo commands that displays the supported pages 3 times. It's been like this the entire time but i am not sure why exactly this is happening. will need further investigation

@aronwk-aaron aronwk-aaron changed the title feat: showall, findplayer, get/openhttpmoninfo, debug feat: slashcommsnds for showall, findplayer, get/openhttpmoninfo, and debug world packet Apr 10, 2024
@aronwk-aaron aronwk-aaron changed the title feat: slashcommsnds for showall, findplayer, get/openhttpmoninfo, and debug world packet feat: slashcommands for showall, findplayer, get/openhttpmoninfo, and debug world packet Apr 10, 2024
dChatServer/ChatPacketHandler.cpp Outdated Show resolved Hide resolved
dChatServer/ChatPacketHandler.cpp Outdated Show resolved Hide resolved
dChatServer/ChatPacketHandler.cpp Outdated Show resolved Hide resolved
dChatServer/ChatPacketHandler.cpp Outdated Show resolved Hide resolved
dChatServer/PlayerContainer.h Outdated Show resolved Hide resolved
dNet/WorldPackets.h Outdated Show resolved Hide resolved
@EmosewaMC
Copy link
Collaborator

also remember reference (for structures larger than 8 bytes) in function arguments when possible if a copy is not necessary :)

@EmosewaMC
Copy link
Collaborator

image There is a quirk with httpmoninfo commands that displays the supported pages 3 times. It's been like this the entire time but i am not sure why exactly this is happening. will need further investigation

will look into this

@aronwk-aaron aronwk-aaron requested a review from EmosewaMC April 12, 2024 02:19
EmosewaMC
EmosewaMC previously approved these changes Apr 12, 2024
@EmosewaMC
Copy link
Collaborator

image There is a quirk with httpmoninfo commands that displays the supported pages 3 times. It's been like this the entire time but i am not sure why exactly this is happening. will need further investigation

will look into this

Confirmed to be a bug in the client. This bug is not solvable without client mods. Please utilize another method from the server to communicate the same information from the server.

@aronwk-aaron
Copy link
Member Author

aronwk-aaron commented Apr 12, 2024

Please utilize another method from the server to communicate the same information from the server.

Will just use this packet with the bug, since there is other functionality that does work in the handle for that packet (such as opening the webpage for /openhttpmoninfo)
From the discussion in discord, this is a bug in the client. but other than the undefined behavior quirkiness which causes the chat messages to display incorrectly, it's not a big issue?

@EmosewaMC
Copy link
Collaborator

Please utilize another method from the server to communicate the same information from the server.

Will just use this packet with the bug, since there is other functionality that does work in the handle for that packet (such as opening the webpage for /openhttpmoninfo) From the discussion in discord, this is a bug in the client. but other than the undefined behavior quirkiness which causes the chat messages to display incorrectly, it's not a big issue?

Http monitor isn't even implemented, so this is introducing a new bug for zero benefit. If you implement the http monitor then you can use the packet, aside from that there's no point. There are probably other ways to get the shell window open anyways that don't involve that gm.

@aronwk-aaron
Copy link
Member Author

aronwk-aaron commented Apr 13, 2024

when ahead and removed the commands for now, will add them back with a workaround for this bug once we actually have the http endpoint

@aronwk-aaron aronwk-aaron requested a review from EmosewaMC April 13, 2024 03:31
Copy link
Collaborator

@jadebenn jadebenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aronwk-aaron aronwk-aaron merged commit 99e7349 into main Apr 18, 2024
4 checks passed
@EmosewaMC
Copy link
Collaborator

dont forget, there is a way to do exactly the behavior of the httpmon work on the server only to fix the client bug.

@EmosewaMC EmosewaMC deleted the showall-find branch April 18, 2024 07:14
@aronwk-aaron
Copy link
Member Author

yeet, got it written down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants