-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: slashcommands for showall, findplayer, get/openhttpmoninfo, and debug world packet #1545
Conversation
http monitor info is planned to be used later, just putting in info that i've since reverse engineered and don't want lost Additionally add debug world packet for duture dev use Tested all new commands and variation of command arguments
also remember reference (for structures larger than 8 bytes) in function arguments when possible if a copy is not necessary :) |
Will just use this packet with the bug, since there is other functionality that does work in the handle for that packet (such as opening the webpage for |
Http monitor isn't even implemented, so this is introducing a new bug for zero benefit. If you implement the http monitor then you can use the packet, aside from that there's no point. There are probably other ways to get the shell window open anyways that don't involve that gm. |
when ahead and removed the commands for now, will add them back with a workaround for this bug once we actually have the http endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
dont forget, there is a way to do exactly the behavior of the httpmon work on the server only to fix the client bug. |
yeet, got it written down |
/showall
and/findplayer
use custom packets and are live accurate/who
variations/gethttpmoninfo
and/openhttpmoninfo
are planned to be used later, just putting in info since it's been RE-d and don't want it lostAdditionally add debug worldPacket for future dev use
Tested all new commands and variation of command arguments